From owner-freebsd-hackers Mon Jan 13 11:35:33 2003 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 745CC37B401 for ; Mon, 13 Jan 2003 11:35:32 -0800 (PST) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id 91C4843E4A for ; Mon, 13 Jan 2003 11:35:31 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 31198 invoked from network); 13 Jan 2003 19:35:36 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail15.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 13 Jan 2003 19:35:36 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id h0DJZTUT003343; Mon, 13 Jan 2003 14:35:29 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200301121010.h0CAAcr4081370@apollo.backplane.com> Date: Mon, 13 Jan 2003 14:35:40 -0500 (EST) From: John Baldwin To: Matthew Dillon Subject: RE: possible cpu_wait() / vm_waitproc() / MAC problem Cc: rwatson@freebsd.org, hackers@freebsd.org Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 12-Jan-2003 Matthew Dillon wrote: > While working on an MFC I noticed that sys/compat/svr4/svr4_misc.c > (in CURRENT) is calling cpu_wait() in svr4_sys_waitsys() instead of > vm_waitproc(). I believe it needs to call vm_waitproc(). Can anyone > say for sure? > > Also, in kern/kern_exit.c the wait code has this: > >#ifdef MAC > mac_destroy_proc(p) >#endif > > This appears to be missing from svr4_sys_waitsys() as well, also > in -current. Could someone confirm that? The svr4() wait code is just gross. We need to make it just pass a flag into wait1() IMO and have the svr4() implementation be a wrapper function. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message