From owner-freebsd-ports-bugs@freebsd.org Thu Mar 1 12:59:49 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02789F276B7 for ; Thu, 1 Mar 2018 12:59:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 94289832D0 for ; Thu, 1 Mar 2018 12:59:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id DE5521BAB for ; Thu, 1 Mar 2018 12:59:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w21CxlkC097363 for ; Thu, 1 Mar 2018 12:59:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w21CxlqZ097362 for freebsd-ports-bugs@FreeBSD.org; Thu, 1 Mar 2018 12:59:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 226221] GH_TUPLE fails to deal with submodules inside a submodule Date: Thu, 01 Mar 2018 12:59:47 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2018 12:59:49 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226221 --- Comment #3 from commit-hook@freebsd.org --- A commit references this bug: Author: mat Date: Thu Mar 1 12:58:53 UTC 2018 New revision: 463301 URL: https://svnweb.freebsd.org/changeset/ports/463301 Log: Fix a sub-submodule extraction problem with GH_SUBDIR. The problem is that GH_SUBDIR are handled in a somewhat random manner. (= The truth is that in the end of things, they end up being sorted by the group name being used in the GH_TUPLE.) So if you have a submodule in bar/foo, and a sub-submodule in bar/foo/baz= , it may happen that foo/bar/baz is handled before foo/bar and then things are messed up. This makes it so the GH_SUBDIR target handling is sorted first by the number of / in the path. (So, bar/foo is always handled before bar/foo/baz.) PR: 226221 Reported by: ygy Sponsored by: Absolight Differential Revision: https://reviews.freebsd.org/D14532 Changes: head/Mk/bsd.sites.mk --=20 You are receiving this mail because: You are on the CC list for the bug.=