From owner-svn-src-all@FreeBSD.ORG Wed Feb 18 21:35:25 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 119E33EC for ; Wed, 18 Feb 2015 21:35:25 +0000 (UTC) Received: from nm32-vm7.bullet.mail.bf1.yahoo.com (nm32-vm7.bullet.mail.bf1.yahoo.com [72.30.239.143]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B9265ED2 for ; Wed, 18 Feb 2015 21:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1424294935; bh=IEHgDFDIMgcmgQDv6uRak/1gbF1K8OjBrBWafPbUZ74=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=IytLzQjTHXP+rsX79LQ/KbNpPr+jo45FKaFPw5Fm0TK4qf84PEHPzccG7YOKQLXGyD94L8ex6s/krKxfdIWAlWNic4TPKyEjCG1aXCjokTbtjnuS9Vccka8z6K++lcXiI9SGnzBXYfnv+vLsKyvSsjliJa3ih7kNEdf6aRtR29xN+OHZUwOcujPzGEy4IUFcXXeqp8KWzvUs7tz4Er3nmy7TLJSCkBIaggzjrDHuqmq+Zv1CDQ0dhSVYWtd8gceSxfZx5rLbL5fTrL4jpXWddgNRBX7/sluNxdGaf/jmDZff4+3wLyHFf7x38VAZMRvltAi5nG9U9eVlKrrM0459DQ== Received: from [66.196.81.171] by nm32.bullet.mail.bf1.yahoo.com with NNFMP; 18 Feb 2015 21:28:55 -0000 Received: from [98.139.213.8] by tm17.bullet.mail.bf1.yahoo.com with NNFMP; 18 Feb 2015 21:28:55 -0000 Received: from [127.0.0.1] by smtp108.mail.bf1.yahoo.com with NNFMP; 18 Feb 2015 21:28:55 -0000 X-Yahoo-Newman-Id: 141403.94464.bm@smtp108.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: W5YbimYVM1l5pSrAAJMYQsFgr4VTXDR_1gA22kQNX13BLwo EpY8EWRe2nYegtUtCx8piRtCFvVosYl489XJDyOSRxoo7vCUpy3DAYj71Qtn LFIDj98vXq4Q3HrwOsmciFFzPsERD62WEnaZ_AAA9s5FOV42SHlsrDlUtFyl nskFKaC4ff7sk_wgIwUeMlOtB9X6mbnX4Y1tlqejlaEfJoXuEYToIDkpON2B WsugZzl7E50uWGZNvbQl38qXlWdax.tXaztA8uCqDerXAovyx_qlyYiiMInG BrYVjviSCpNfEpm8whflVLPN_kzkWXp6jEc9Ycc07uIGJtpjwV0iRLKJnRxO _rCObSa.IFsNs_c7q52PC1oUeQewy5M1WDs.uT7lUBG5vd3aGI5.l4gF2eDG PdIbr3K48yoTlGkGIwY_MxL_gqA8lGHgVKNrbcNt09qWItQ6rwFuWml3HV_u QGRG3F2mwq2KuJDVls67LdMstC7.10BZnW_eB45.lPdLfa0Anr4DwmH0gh.o lnS0RVaqX7X3xylJETGwORcrIc_tIzgBZ X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <54E50419.3030106@FreeBSD.org> Date: Wed, 18 Feb 2015 16:28:57 -0500 From: Pedro Giffuni Organization: FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rui Paulo , Steven Hartland Subject: Re: svn commit: r277300 - in head: cddl/contrib/opensolaris/cmd/dtrace cddl/contrib/opensolaris/cmd/lockstat cddl/contrib/opensolaris/cmd/mdb/tools/common cddl/contrib/opensolaris/cmd/plockstat cddl/co... References: <5f8079b1-ae7d-4977-99f6-a8fd0f3f8252@me.com> In-Reply-To: <5f8079b1-ae7d-4977-99f6-a8fd0f3f8252@me.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 21:35:25 -0000 On 18/02/2015 01:36 p.m., Rui Paulo wrote: > On Jan 17, 2015, at 06:45 AM, Steven Hartland wrote: > >> Author: smh >> Date: Sat Jan 17 14:44:59 2015 >> New Revision: 277300 >> URL: https://svnweb.freebsd.org/changeset/base/277300 >> >> Log: >> Mechanically convert cddl sun #ifdef's to illumos >> >> Since the upstream for cddl code is now illumos not sun, mechanically >> convert all sun #ifdef's to illumos #ifdef's which have been used in all >> newer code for some time. >> FWIW, we should probably "svn move" contrib/cddl/opensolaris to contrib/cddl/illumos as well. "opensolaris" doesn't exist anymore but "illumos" is also shorter. >> Also do a manual pass to correct the use if #ifdef comments as per >> style(9) >> as well as few uses of #if defined(__FreeBSD__) vs #ifndef illumos. > I had just convinced Mark Johnston to use "#ifdef __FreeBSD__" instead > of "#ifndef illumos". Is there a reason why we keep using #ifndef ? > To me, it's much easier to read #ifdef __FreeBSD__ than to note > whether theres an "n" in that pre-processor macro. > Pedro.