From owner-freebsd-current@FreeBSD.ORG Tue Nov 25 23:05:48 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F11B316A4CE for ; Tue, 25 Nov 2003 23:05:48 -0800 (PST) Received: from helios.earthmagic.org (helios.earthmagic.org [198.78.66.220]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB35243FDD for ; Tue, 25 Nov 2003 23:05:47 -0800 (PST) (envelope-from lonewolf-freebsd@earthmagic.org) Received: (qmail 42556 invoked from network); 26 Nov 2003 07:05:47 -0000 Received: from ppp149-54.lns1.mel2.internode.on.net (HELO earthmagic.org) (lonewolf@150.101.149.54) by helios.earthmagic.org with RC4-MD5 encrypted SMTP; 26 Nov 2003 07:05:47 -0000 Message-ID: <3FC450C8.9070208@earthmagic.org> Date: Wed, 26 Nov 2003 18:05:44 +1100 From: Johny Mattsson User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030524 X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-current@freebsd.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: Getting USB detach events enabled in time for 5.2-R? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Nov 2003 07:05:49 -0000 Hi all, I was wondering if there's any possibility in getting USB detach events working in time for the 5.2 release? The PR in question is kern/46488, and I submitted patches for this issue quite a while ago (Oct 24). Unfortunately jmg appears to be busy with other things as I have been unable to get in touch with him to discuss this one. The basic issue is that currently no USB detach events are delivered when a device detaches. The particular call to do so is commented out in usb_subr.c, and I discovered why when I brought it back in action - Instant Panic(tm) on detach for some devices. I rooted out why it happens and provided patches for it (see specifics in the PR and referenced emails there). The changes are quite small (~5 lines), and have been verified by others than myself. My reasoning for wanting this fixed in time for 5.2-R is that it's functionality advertised in the manpages for e.g. usbd(8), and it's quite important for people who rely on external USB keyboards for their laptops, amongst other things. If I'm being too pushy about this, then my apologies, but I wanted to bring this one into the spotlight for a moment since I think it's a good tradeoff in terms of functionality gained vs effort involved. If I can be of any further assistance in regards to this, please let me know. Regards, /Johny -- Johny Mattsson - System Designer ,-. ,-. ,-. There is no truth. http://www.earthmagic.org _.' `-' `-' There is only perception.