From owner-freebsd-stable@FreeBSD.ORG Mon Feb 4 03:52:53 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6670916A419 for ; Mon, 4 Feb 2008 03:52:53 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.224]) by mx1.freebsd.org (Postfix) with ESMTP id 0B64013C50C for ; Mon, 4 Feb 2008 03:52:52 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wx-out-0506.google.com with SMTP id i29so1640921wxd.7 for ; Sun, 03 Feb 2008 19:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=n5qQ5DHzfnqZvDf6QdKZMeFdImnqDIJz/VtaUI7HPQo=; b=SbBlyo/6U1UwHeIcx9UT8Xk6ZVdNxxPwoSjIkUjNEu/6qYx3yJYEoIyBxxdT37U7xhTZJ+QJTJbibW85s0BSJLTs7+B1dsHW3CqF4QRH3FsJHdXD2EwN54fKmjoFR7dh4kCIItL/AWRJj3OeesbICmLXG2ir9+vRyGeJlq2W8gk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=xOBglg+gy23r1+B3SEngE6OKTTUPiVNmkYC7aG8i1YMN1qLMea7/0UC0hJTdmrkdxaJ2gUhnr9fSL4dYt5Lj1UtxyKod3r3JczmCWgG5hGBSgOTbJhmGhX3GUOjO3QoU0Dp9846XesXB+dytMtTeWbbbcwGbTLc3ZyvmochiR7M= Received: by 10.150.189.9 with SMTP id m9mr2727960ybf.142.1202097172399; Sun, 03 Feb 2008 19:52:52 -0800 (PST) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id 5sm12124264wrh.27.2008.02.03.19.52.48 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 03 Feb 2008 19:52:50 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id m143qiLd028721 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 4 Feb 2008 12:52:45 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id m143qgI6028720; Mon, 4 Feb 2008 12:52:42 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Mon, 4 Feb 2008 12:52:42 +0900 From: Pyun YongHyeon To: Andriy Gapon Message-ID: <20080204035242.GA28554@cdnetworks.co.kr> References: <47A3041D.5050402@icyb.net.ua> <20080201123603.GA14050@cdnetworks.co.kr> <47A321BB.1060708@icyb.net.ua> <47A32501.7080703@icyb.net.ua> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: <47A32501.7080703@icyb.net.ua> User-Agent: Mutt/1.4.2.1i Cc: freebsd-stable@freebsd.org, yongari@freebsd.org Subject: Re: 6.3 nfe: strange behavior after hand X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 03:52:53 -0000 --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 01, 2008 at 03:56:17PM +0200, Andriy Gapon wrote: > on 01/02/2008 15:42 Andriy Gapon said the following: > > on 01/02/2008 14:36 Pyun YongHyeon said the following: > >> After applying attached patch and let me know the output of > >> "devid : xxx, revid : xxx, pwr = xxx". It would be even better > >> if you can show me the above message for working/non-working case. > >> > >> > > > > Applied the patch with correction to actually print rev instead of dev > > for the second time :-) > > This is in working case: > > devid : 269, revid : a3, pwr = 00000003 > > A clarification: I just applied the patch, recompiled and re-loaded the > module. There was no reboot/poweroff/reset in between. > > > Will wait for the non-working situation. > > > Revert previous patch and try attached patch again and let me know how it goes. -- Regards, Pyun YongHyeon --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="nfe.diff2" --- sys/dev/nfe/if_nfe.c.orig 2008-02-02 04:36:24.000000000 +0900 +++ sys/dev/nfe/if_nfe.c 2008-02-04 12:47:11.000000000 +0900 @@ -763,12 +763,6 @@ if ((sc->nfe_flags & NFE_PWR_MGMT) == 0) return; - NFE_WRITE(sc, NFE_RXTX_CTL, NFE_RXTX_RESET | NFE_RXTX_BIT2); - NFE_WRITE(sc, NFE_MAC_RESET, NFE_MAC_RESET_MAGIC); - DELAY(100); - NFE_WRITE(sc, NFE_MAC_RESET, 0); - DELAY(100); - NFE_WRITE(sc, NFE_RXTX_CTL, NFE_RXTX_BIT2); pwr = NFE_READ(sc, NFE_PWR2_CTL); pwr &= ~NFE_PWR2_WAKEUP_MASK; if (sc->nfe_revid >= 0xa3 && @@ -776,6 +770,12 @@ sc->nfe_devid == PCI_PRODUCT_NVIDIA_NFORCE430_LAN2)) pwr |= NFE_PWR2_REVA3; NFE_WRITE(sc, NFE_PWR2_CTL, pwr); + NFE_WRITE(sc, NFE_RXTX_CTL, NFE_RXTX_RESET | NFE_RXTX_BIT2); + NFE_WRITE(sc, NFE_MAC_RESET, NFE_MAC_RESET_MAGIC); + DELAY(100); + NFE_WRITE(sc, NFE_MAC_RESET, 0); + DELAY(100); + NFE_WRITE(sc, NFE_RXTX_CTL, NFE_RXTX_BIT2); } --7AUc2qLy4jB3hD7Z--