From owner-svn-src-head@freebsd.org Fri Aug 12 18:34:45 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3503FBB7384; Fri, 12 Aug 2016 18:34:45 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22f.google.com (mail-pf0-x22f.google.com [IPv6:2607:f8b0:400e:c00::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0683C152C; Fri, 12 Aug 2016 18:34:45 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22f.google.com with SMTP id p64so11346028pfb.1; Fri, 12 Aug 2016 11:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=nhtRYelolxTgNwxLF6BvyU4/cyMaFiWn769FCHQuyBQ=; b=jWFS1jZ0kxH2v1nsJ/yp5EoP0dmoYr3r9Pek9yfoaxK7DgkMmajf+4fIHuCcKLurWN Ds9t97zMygK2h9IJeZis9oGffvriUCemEbgtcuam5Gl1VyPXWXlNlKfaSj9uM4rbQxfs uyFcDbLFGm8MUWRmZHGQtDVLXUwi23u3WiWxX9+fRjdoBx+d69uSv8mGTUSb8Kf/3yjk BafMM++v8ANz4eA2ZAm0dqIBkHxoc9j+20NL3/q+/k1f+U9q2NjmO+67F/s4k+sdDFvI UnNGFlg9k6tYwtdJq9H6posM2Y0d6L+/Yph3yaEAbJLDj2jmWHpt1jb70oU1s8la5Hz5 cRiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=nhtRYelolxTgNwxLF6BvyU4/cyMaFiWn769FCHQuyBQ=; b=gLPjUL+Wgmj4E0VDBQzv3z54TfkrjW43jw2KbRcdoGV8h7uBrDsxLlmIgo7FcgHw7H gNuze3y1n3m/6TkwX2kFPPMzUg7UR+qeEBl9slrFxs8naZV+bMb0BolALRXK1OHp30Qb SFQ9JLAPAbI5e26EM5OqvPx2bE7eJXxdlAAHa1UljyznY93IKtJdfMj8jdCpQHNOOsgn zvm4wM1UcmY2qFK367K5TROfx3XbTAmtIER/r/Ga4XVB8xrCNxBx06nf/1L3tN335iSn cGX7LOJ35dWDlmXSM8bCpQE2kziq8fRuPx3fQVJEjI1KRbbFrZKSw8O9F4FJIwOsCbiR kzPA== X-Gm-Message-State: AEkooutRO8B3iIJgahw0xcTC2V8KHT/RmMV/8jhKVx9Cc27df8vDrlTrOu1vikDxJYn6XQ== X-Received: by 10.98.70.199 with SMTP id o68mr29657093pfi.17.1471026884406; Fri, 12 Aug 2016 11:34:44 -0700 (PDT) Received: from [21.183.82.46] ([172.56.42.252]) by smtp.gmail.com with ESMTPSA id vt10sm14724165pab.43.2016.08.12.11.34.43 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 12 Aug 2016 11:34:43 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r304011 - head/libexec/rtld-elf From: Ngie Cooper X-Mailer: iPhone Mail (13G35) In-Reply-To: <201608121829.u7CITCIu059447@repo.freebsd.org> Date: Fri, 12 Aug 2016 11:34:42 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <35B0B56E-A536-4A07-B397-7E5ABAB4CB34@gmail.com> References: <201608121829.u7CITCIu059447@repo.freebsd.org> To: Konstantin Belousov X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 18:34:45 -0000 > On Aug 12, 2016, at 11:29, Konstantin Belousov wrote: >=20 > Author: kib > Date: Fri Aug 12 18:29:11 2016 > New Revision: 304011 > URL: https://svnweb.freebsd.org/changeset/base/304011 >=20 > Log: > Remove all remaining uses of TAILQ_FOREACH_FROM() from rtld-elf. Why? > Sponsored by: The FreeBSD Foundation > MFC after: 1 week >=20 > Modified: > head/libexec/rtld-elf/rtld.c >=20 > Modified: head/libexec/rtld-elf/rtld.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/libexec/rtld-elf/rtld.c Fri Aug 12 18:07:44 2016 (r304010) > +++ head/libexec/rtld-elf/rtld.c Fri Aug 12 18:29:11 2016 (r304011) > @@ -2164,8 +2164,7 @@ load_needed_objects(Obj_Entry *first, in > { > Obj_Entry *obj; >=20 > - obj =3D first; > - TAILQ_FOREACH_FROM(obj, &obj_list, next) { > + for (obj =3D first; obj !=3D NULL; obj =3D TAILQ_NEXT(obj, next)) { > if (obj->marker) > continue; > if (process_needed(obj, obj->needed, flags) =3D=3D -1) > @@ -2769,9 +2768,8 @@ relocate_objects(Obj_Entry *first, bool=20 > Obj_Entry *obj; > int error; >=20 > - error =3D 0; > - obj =3D first; > - TAILQ_FOREACH_FROM(obj, &obj_list, next) { > + for (error =3D 0, obj =3D first; obj !=3D NULL; > + obj =3D TAILQ_NEXT(obj, next)) { > if (obj->marker) > continue; > error =3D relocate_object(obj, bind_now, rtldobj, flags, > @@ -2811,8 +2809,7 @@ resolve_objects_ifunc(Obj_Entry *first,=20 > { > Obj_Entry *obj; >=20 > - obj =3D first; > - TAILQ_FOREACH_FROM(obj, &obj_list, next) { > + for (obj =3D first; obj !=3D NULL; obj =3D TAILQ_NEXT(obj, next)) { > if (obj->marker) > continue; > if (resolve_object_ifunc(obj, bind_now, flags, lockstate) =3D=3D -1= ) > @@ -4316,7 +4313,7 @@ trace_loaded_objects(Obj_Entry *obj) >=20 > list_containers =3D getenv(_LD("TRACE_LOADED_OBJECTS_ALL")); >=20 > - TAILQ_FOREACH_FROM(obj, &obj_list, next) { > + for (; obj !=3D NULL; obj =3D TAILQ_NEXT(obj, next)) { > Needed_Entry *needed; > char *name, *path; > bool is_lib; > @@ -4661,8 +4658,7 @@ allocate_tls(Obj_Entry *objs, void *oldt > */ > free_tls(oldtls, 2*sizeof(Elf_Addr), sizeof(Elf_Addr)); > } else { > - obj =3D objs; > - TAILQ_FOREACH_FROM(obj, &obj_list, next) { > + for (obj =3D objs; obj !=3D NULL; obj =3D TAILQ_NEXT(obj, next)) { > if (obj->marker || obj->tlsoffset =3D=3D 0) > continue; > addr =3D segbase - obj->tlsoffset; >=20