From owner-freebsd-arch@FreeBSD.ORG Thu May 15 13:50:13 2014 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8857176C; Thu, 15 May 2014 13:50:13 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EA61D29F4; Thu, 15 May 2014 13:50:12 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.8/8.14.8) with ESMTP id s4FDo3Kh040309; Thu, 15 May 2014 16:50:03 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua s4FDo3Kh040309 Received: (from kostik@localhost) by tom.home (8.14.8/8.14.8/Submit) id s4FDo3sr040306; Thu, 15 May 2014 16:50:03 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 15 May 2014 16:50:03 +0300 From: Konstantin Belousov To: Oliver Pinter Subject: Re: [RFC] remove dead code from link_elf.c Message-ID: <20140515135003.GO74331@kib.kiev.ua> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wmfuW8osuO2pi9jF" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: arch@freebsd.org, gavin@freebsd.org, current@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2014 13:50:13 -0000 --wmfuW8osuO2pi9jF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 15, 2014 at 03:36:51PM +0200, Oliver Pinter wrote: > Hi all! >=20 > I found that the SPARSE_MAPPING used only in sys/kern/link_elf.c file, > and no other place in kernel, nor in generated codes in /usr/obj/... >=20 > op@pandora-d opBSD.git> git grep -i SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING >=20 > I proposed to remove the old/dead codes. Patch attached. Tested on amd64. I agree that SPARSE_MAPPING could go away. But your testing is void, since link_elf.c is practically not used on amd64, which utilizes object file format for klds. --wmfuW8osuO2pi9jF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJTdMYKAAoJEJDCuSvBvK1Bu34P/ikDUz/j+RAq/Xk/dMznoHFx 27A7ym8WOOA4EN/GnCMdOgN7CJNCFeBBLNpBtfafISNJlxUbjJAJVFkxv3WuR591 tivRbG+0o26+3cSe8jF6CB4p7zfpG9qJ3qvXyo3RMeuWxZrBTKUk4JOy3rgK08+j WdBFybCHqyZnskCQcJTs9Hbifhnnb+La/YBkAfK1vP5h8UPrh7GUY8ES9gntn44R okKQKXvGGyZtM652Gb/ViIFtTdmjRW2VBjNyhPSXwcC3DTJOKFW/2sc7wJP6IiKg 8tOr2UvD01wqDJ9QTsMtIgaKXhHdiUbi7CRxoKE6JWamCat8YJ+K93x/HA1DXj8m ZqoIQ7mSVY/8LumnyOktN+9Qc1TYUVcEpQrbooAXELaHrRkwHUCkdcBTmipSr9LN C873CAakAP4+w4ZkWRWcewXAG0zZanYjBuvRVaLfgknT8ehzKFrBgOCTm/jd9hR2 jznuMcoQkXtKKXlHNIcprOZXb2rJvb/qndETqITo35oBcB2Fu9do3qMDsjKDuH9n aFFXHVB84EQxwZ6TGVexioegewkrRiIlsx3Cj/Su+RvMGocTDrgcLMEKBoI6eGzd FGOE74PbVN3ZVDLcGWbfeUIYuHEgg0gzIfeKsbqAu5c7SeUD/8/D1bMYK2mWVA35 fvBB5dgSfpK07RMs8dkb =uqHx -----END PGP SIGNATURE----- --wmfuW8osuO2pi9jF--