From owner-svn-ports-head@FreeBSD.ORG Tue Nov 26 07:38:58 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 184665A4; Tue, 26 Nov 2013 07:38:58 +0000 (UTC) Received: from mail-wi0-x22e.google.com (mail-wi0-x22e.google.com [IPv6:2a00:1450:400c:c05::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A53DA283C; Tue, 26 Nov 2013 07:38:56 +0000 (UTC) Received: by mail-wi0-f174.google.com with SMTP id ey16so15138wid.13 for ; Mon, 25 Nov 2013 23:38:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=aBId44jVxwL/CFA6TJ1WeNw8xL4CfADs2c2ogOU8Cg0=; b=K/xqrpPf1K12/fp1PFrN7TprsMkVEXnfbs2q9UcQaEbDeW0ZVjG4qDuzsJTiECkYQb N//utk+5EEkRjf03xDLR/szP+RqG/gQ7bCfkLTzEEH0vRlP+MMFOAbyE021FAxbQor4X 5NsLQSFnGj6fBrpmdRqHCiuufuHvXX57HY9ME/GfrYqAGC5hIswRxYmEAsXQopw4IHQN 9F5nyZTPcqGFsZ1CJD+L53yCexiHFqqOsgOhHFbX1DVAAg4ba0CbNr7g3YtRsGLyOPR6 VJfgPN2kT/TqRx6eewqNbtuiLmJWtrZCxDGjoqiolVA7VUu8l7JdMJumwDdal1BX8/3M jwIg== X-Received: by 10.181.5.40 with SMTP id cj8mr16780027wid.18.1385451535012; Mon, 25 Nov 2013 23:38:55 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id je17sm57474095wic.4.2013.11.25.23.38.53 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 25 Nov 2013 23:38:54 -0800 (PST) Sender: Baptiste Daroussin Date: Tue, 26 Nov 2013 08:38:52 +0100 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r334593 - in head/dns: bind96 bind96/files bind98 bind98/files bind99 bind99/files Message-ID: <20131126073851.GE19582@ithaqua.etoilebsd.net> References: <201311221341.rAMDfY3g002148@svn.freebsd.org> <01490d316b5dd7f01f1c843871542666@secure.marino.st> <2DEEB271-4795-4DF0-8F85-30316BA3070F@FreeBSD.org> <5291C8BD.3070109@marino.st> <20131126035339.GA43389@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CGDBiGfvSTbxKZlW" Content-Disposition: inline In-Reply-To: <20131126035339.GA43389@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org, Erwin Lansing X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Nov 2013 07:38:58 -0000 --CGDBiGfvSTbxKZlW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 26, 2013 at 03:53:39AM +0000, Alexey Dokuchaev wrote: > On Sun, Nov 24, 2013 at 10:37:01AM +0100, John Marino wrote: > > I have attached a diff with the proposed changes covering all three > > ports. It's pretty straight-forward. > > =20 > > .if ${PORT_OPTIONS:MREPLACE_BASE} > > -.if ${OSVERSION} >=3D 1000500 > > +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1000500 >=20 > Given that OSVERSION is used extensively in the tree, I'm worrying that > adding these extra "${OPSYS} =3D=3D FreeBSD" checks will our makefiles le= ss > readable. Wouldn't it make more sense to place this check somewhere in > single place, and define whatever OSVERSION that looks reasonable when > OPSYS =3D=3D FreeBSD instead of patching every port? >=20 > ./danfe except that lots/most of the osversion checking in the ports tree is also w= rong and was due to a design bug of pointyhat/tinderbox, pointyhat is gone, and tinderbox had been fixed. there is no need anymore for most of them which a= lso are often wrong given the flexibility we have with buildworld. I do plan to remove most of the useless osversion. regards, Bapt --CGDBiGfvSTbxKZlW Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlKUUAsACgkQ8kTtMUmk6ExIwgCdF336k4IlAVvo0K+xdfwzKCQ1 GCMAniU0iAmkUdouastuu10mlmkDQLNQ =ZwHk -----END PGP SIGNATURE----- --CGDBiGfvSTbxKZlW--