Date: Tue, 26 Nov 2013 08:38:52 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org, Erwin Lansing <erwin@FreeBSD.org> Subject: Re: svn commit: r334593 - in head/dns: bind96 bind96/files bind98 bind98/files bind99 bind99/files Message-ID: <20131126073851.GE19582@ithaqua.etoilebsd.net> In-Reply-To: <20131126035339.GA43389@FreeBSD.org> References: <201311221341.rAMDfY3g002148@svn.freebsd.org> <01490d316b5dd7f01f1c843871542666@secure.marino.st> <2DEEB271-4795-4DF0-8F85-30316BA3070F@FreeBSD.org> <5291C8BD.3070109@marino.st> <20131126035339.GA43389@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--CGDBiGfvSTbxKZlW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Nov 26, 2013 at 03:53:39AM +0000, Alexey Dokuchaev wrote:
> On Sun, Nov 24, 2013 at 10:37:01AM +0100, John Marino wrote:
> > I have attached a diff with the proposed changes covering all three
> > ports. It's pretty straight-forward.
> > =20
> > .if ${PORT_OPTIONS:MREPLACE_BASE}
> > -.if ${OSVERSION} >=3D 1000500
> > +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1000500
>=20
> Given that OSVERSION is used extensively in the tree, I'm worrying that
> adding these extra "${OPSYS} =3D=3D FreeBSD" checks will our makefiles le=
ss
> readable. Wouldn't it make more sense to place this check somewhere in
> single place, and define whatever OSVERSION that looks reasonable when
> OPSYS =3D=3D FreeBSD instead of patching every port?
>=20
> ./danfe
except that lots/most of the osversion checking in the ports tree is also w=
rong
and was due to a design bug of pointyhat/tinderbox, pointyhat is gone, and
tinderbox had been fixed. there is no need anymore for most of them which a=
lso
are often wrong given the flexibility we have with buildworld.
I do plan to remove most of the useless osversion.
regards,
Bapt
--CGDBiGfvSTbxKZlW
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlKUUAsACgkQ8kTtMUmk6ExIwgCdF336k4IlAVvo0K+xdfwzKCQ1
GCMAniU0iAmkUdouastuu10mlmkDQLNQ
=ZwHk
-----END PGP SIGNATURE-----
--CGDBiGfvSTbxKZlW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131126073851.GE19582>