Date: Wed, 20 Feb 2013 22:31:05 +1300 From: Andrew Turner <andrew@fubar.geek.nz> To: Alan Cox <alc@rice.edu> Cc: "arm@freebsd.org" <arm@freebsd.org> Subject: Re: svn commit: r246926 - in head/sys: arm/arm arm/include vm Message-ID: <20130220223105.4b71c62f@bender> In-Reply-To: <5123BD37.7070709@rice.edu> References: <201302180102.r1I12nMX049209@svn.freebsd.org> <20130219083455.176129d3@bender> <5123BD37.7070709@rice.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 19 Feb 2013 11:58:15 -0600 Alan Cox <alc@rice.edu> wrote: > On 02/18/2013 13:34, Andrew Turner wrote: > > On Mon, 18 Feb 2013 01:02:49 +0000 (UTC) > > Alan Cox <alc@FreeBSD.org> wrote: > > > >> Author: alc > >> Date: Mon Feb 18 01:02:48 2013 > >> New Revision: 246926 > >> URL: http://svnweb.freebsd.org/changeset/base/246926 > >> > >> Log: > >> On arm, like sparc64, the end of the kernel map varies from one > >> type of machine to another. Therefore, VM_MAX_KERNEL_ADDRESS can't > >> be a constant. Instead, #define it to be a variable, > >> vm_max_kernel_address, just like we do on sparc64. > > This looks to be broken on non-FDT ARM. There are still a number of > > copies of initarm for older ports without FDT that will need > > vm_max_kernel_address to be set. > > Thanks for pointing this out. I believe that the attached patch adds > the necessary initialization to all of the non-FDT platforms. Since I > had to edit most of the pmap_bootstrap() calls, I also eliminated the > redundant second argument. That patch looks correct and produces what appears to be a correct value on at91. Without the patch I get: # sysctl vm.max_kernel_address vm.max_kernel_address: 0 With the patch I get: # sysctl vm.max_kernel_address vm.max_kernel_address: 3623911424 I've checked this value for this board to be correct for the method at91 uses to calculate vm_max_kernel_address. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130220223105.4b71c62f>