From owner-svn-src-head@FreeBSD.ORG  Fri Jul 16 21:41:55 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4E1AD106566C;
	Fri, 16 Jul 2010 21:41:55 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 0AA038FC19;
	Fri, 16 Jul 2010 21:41:54 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o6GLfrAW003086;
	Fri, 16 Jul 2010 15:41:53 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Fri, 16 Jul 2010 15:42:16 -0600 (MDT)
Message-Id: <20100716.154216.582095686063971712.imp@bsdimp.com>
To: jkim@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <201007161514.04955.jkim@FreeBSD.org>
References: <201007131657.o6DGvq9L097594@svn.freebsd.org>
	<20100715220012.X1719@delplex.bde.org>
	<201007161514.04955.jkim@FreeBSD.org>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, brde@optusnet.com.au
Subject: Re: svn commit: r210005 - head/sys/modules/acpi/acpi
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Jul 2010 21:41:55 -0000

In message: <201007161514.04955.jkim@FreeBSD.org>
            Jung-uk Kim <jkim@FreeBSD.org> writes:
: On Thursday 15 July 2010 08:04 am, Bruce Evans wrote:
: > On Tue, 13 Jul 2010, Jung-uk Kim wrote:
: > > Log:
: > >  Define SMP unconditionally for amd64 and remove opt_global.h
: > > from SRCS. Note it is done just for correctness sake because we
: > > do not build, ship, or support acpi.ko on amd64.
: > >
: > >  Prodded by:	bde
: >
: > Thanks.
: >
: > It was much more interesting than I noticed.  Modules are supposed
: > to be independent of all configuration options, especially global
: > ones, especially especially SMP.  Perhaps this is too much to ask
: > for acpi. Does it work now, after you removed an SMP ifdef from it?
: 
: I removed "#ifdef SMP" from acpi.c because 'smp_started' is available 
: for both UP and SMP kernels.  On the other hand, I cannot remove 
: these easily from sys/amd64/acpica/acpi_wakeup.c, i.e., it requires 
: some symbols from sys/amd64/amd64/mp_machdep.c, which are only 
: available in SMP case.
: 
: FYI, we never had to worry about acpi.ko on i386 because we didn't 
: implement suspend/resume for SMP case in the first place. X-)

Does this mean we do implement it on amd64 now?  I may have to start
trying to use it again...

Warner