From owner-freebsd-current@FreeBSD.ORG Sun Dec 7 11:40:38 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E28A16A4CE for ; Sun, 7 Dec 2003 11:40:38 -0800 (PST) Received: from hak.cnd.mcgill.ca (hak.cnd.mcgill.ca [132.216.11.133]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2975443FB1 for ; Sun, 7 Dec 2003 11:40:37 -0800 (PST) (envelope-from mat@hak.cnd.mcgill.ca) Received: from hak.cnd.mcgill.ca (localhost [127.0.0.1]) by hak.cnd.mcgill.ca (8.12.9/8.12.8) with ESMTP id hB7Jbm15003362; Sun, 7 Dec 2003 14:37:49 -0500 (EST) (envelope-from mat@hak.cnd.mcgill.ca) Received: (from mat@localhost) by hak.cnd.mcgill.ca (8.12.9/8.12.8/Submit) id hB7Jbm1c003359; Sun, 7 Dec 2003 14:37:48 -0500 (EST) Date: Sun, 7 Dec 2003 14:37:48 -0500 From: Mathew Kanner To: Poul-Henning Kamp Message-ID: <20031207193748.GB98718@cnd.mcgill.ca> References: <20031207173959.GE42518@cicely12.cicely.de> <26334.1070824422@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26334.1070824422@critter.freebsd.dk> User-Agent: Mutt/1.4.1i Organization: I speak for myself, operating in Montreal, CANADA X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.60 X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on hak.cnd.mcgill.ca cc: freebsd-current@freebsd.org Subject: Re: major number leak with modules? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Dec 2003 19:40:38 -0000 On Dec 07, Poul-Henning Kamp wrote: > In message <20031207173959.GE42518@cicely12.cicely.de>, Bernd Walter writes: > >The situation was the following during driver development. > >It's an USB driver and kldload'ed. > >A plugged in device got major 247 for the nodes it created. > >On unplugging the nodes were destroyed. > >kldunloading the driver and kldloading the next revision created > >nodes with major 246 for new devices. > > > >Do we have a leak with major numbers or is the old major number free > >after last destroy_dev and assigning algorithm just took the next. > > Yes, repeatedly loading/unloading will leak majors. > > I have some ref-counting code to solve this problem. Warners > axe-swinging in the old ISA drivers made it easier, but some necessary > but uncommitted patches to the sound code from cg@ are still at > road-block. Hello Poul-Henning, It's my understanding that Cameron has submitted patches to you. If you have no objection to them, please commit them. Otherwise, I will try to work some patches that are favorable to you. Cheers, --Mat -- The state has no business in the bedrooms of the nation. - Pierre Elliott Trudeau