From owner-freebsd-fs@FreeBSD.ORG Thu Sep 19 01:59:29 2013 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id EB5EF15D for ; Thu, 19 Sep 2013 01:59:29 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B34792754 for ; Thu, 19 Sep 2013 01:59:29 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.17]) by ltcfislmsgpa02.fnfis.com (8.14.5/8.14.5) with ESMTP id r8J1xSDm025462 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 18 Sep 2013 20:59:28 -0500 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.202]) by LTCFISWMSGHT06.FNFIS.com ([10.132.206.17]) with mapi id 14.02.0309.002; Wed, 18 Sep 2013 20:59:27 -0500 From: "Teske, Devin" To: Kirk McKusick Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condition?) Thread-Topic: kern/182181: [ufs] Leakage of vnode references (race condition?) Thread-Index: AQHOtNvfLnUp3A7wAUGOowRuzp3VWQ== Date: Thu, 19 Sep 2013 01:59:27 +0000 Message-ID: <13CA24D6AB415D428143D44749F57D720FBD82DC@LTCFISWMSGMB21.FNFIS.com> References: <201309190024.r8J0ORZD097969@chez.mckusick.com> In-Reply-To: <201309190024.r8J0ORZD097969@chez.mckusick.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.126] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794, 1.0.431, 0.0.0000 definitions=2013-09-19_01:2013-09-18,2013-09-19,1970-01-01 signatures=0 Cc: freebsd-fs , "Teske, Devin" X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2013 01:59:30 -0000 On Sep 18, 2013, at 5:24 PM, Kirk McKusick wrote: >> From: "Teske, Devin" >> To: Rick Macklem >> Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condit= ion?) >> Date: Thu, 19 Sep 2013 00:11:03 +0000 >> Cc: freebsd-fs , >> "Teske, Devin" >>=20 >> On Sep 18, 2013, at 5:05 PM, Rick Macklem wrote: >>=20 >>> Devin Teske wrote: >>>>=20 >>>>=20 >>>> Yes, my confusion was... >>>>=20 >>>> 1. The PR headers say 8.4-RELEASE-p3 is affected >>>>=20 >>>> 2. The PR's "How-To-Repeat" starts with "Install a releng/8.4 branch" >>>>=20 >>>> Yet... >>>>=20 >>>> releng/8.4 and even releng/8.3 both use VOP_UNLOCK instead of vput >>>> (read: are patched). >>>>=20 >>> Did you mean "not patched"? The patched version in head has vput() >>> and the unpatched versions have VOP_UNLOCK(), if I read the coed correc= tly. >>>=20 >>=20 >> Well, Kirk's fat-finger made me think that VOP_UNLOCK was the patched- >> state and vput was the unpatched state. (could also be that I'm fighting >> the flu currently). >>=20 >> So everything is copacetic now, except the one outstanding question... >>=20 >> Should we not MFC r253998 to stable/8? >>=20 >> I'm looking to pull this into our own stable/8 kernel, but would >> like to do it by way of svn merge from the stable/8 branch. >> --=20 >> Devin >=20 > Per your request, I have MFC'ed the patch to 8-stable as revision 255681. >=20 Thanks much! Slurping this into our base now. Again, thanks! --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.