From nobody Mon Jan 13 04:56:23 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YWg2g4Hddz5kW1Y; Mon, 13 Jan 2025 04:56:27 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YWg2d6CN8z58yY; Mon, 13 Jan 2025 04:56:25 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of cy.schubert@cschubert.com designates 3.97.99.32 as permitted sender) smtp.mailfrom=cy.schubert@cschubert.com; dmarc=permerror reason="p tag has invalid value: quarantine rua=mailto:p[ostmaster@cschubert.com" header.from=cschubert.com (policy=permerror) Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id WxByt6fSeIx4rXCUztFpLD; Mon, 13 Jan 2025 04:56:25 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id XCUxtGfAdJhBPXCUytLkks; Mon, 13 Jan 2025 04:56:25 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=QY3Fvdbv c=1 sm=1 tr=0 ts=67849cf9 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=VdSt8ZQiCzkA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=wmRQ95NiUiyAoIyFTwcA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 371EB7F1; Sun, 12 Jan 2025 20:56:23 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 20AFF149; Sun, 12 Jan 2025 20:56:23 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Larry Rosenman cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 0654456e0611 - main - sysutils/lsof: fix breakage after 3a0cdb2675e6 In-reply-to: <202501112057.50BKvD38009217@gitrepo.freebsd.org> References: <202501112057.50BKvD38009217@gitrepo.freebsd.org> Comments: In-reply-to Larry Rosenman message dated "Sat, 11 Jan 2025 20:57:13 +0000." List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 12 Jan 2025 20:56:23 -0800 Message-Id: <20250113045623.20AFF149@slippy.cwsent.com> X-CMAE-Envelope: MS4xfBPfEVd7S30GLlDDEPt3Gv7P0ao64eH771VfZMiSRmwDFm2ndhtc43+7whfL1eAtJrhQoSTjXZra3pVQxQuHEuLEhPgcAFqUqUKW7cm3gQh9ayTPbd/o 52Lo7htbNhd7PLUFnxUXH3tsLJ85hSHlAnkP8Zsow2CFBfohG1Ekmgagv9UkmrHJhRbqBJZULXXPtl+oiUVtIOmZLkScw3csGIF1BVeNL4RAqWR7GQT7bcdX biOIigP+QgtcYnReE2++F6enTX0P2t3UC6yaj6cMFu2Yjzo6yX5yKC8awXjguMm9WLIdSyZQ3+f2b01GQhgStZSg60Q0UXkbwDFcPbSWs4E= X-Spamd-Result: default: False [-1.80 / 15.00]; RBL_SENDERSCORE_REPUT_9(-1.00)[3.97.99.32:from]; NEURAL_HAM_SHORT(-0.90)[-0.899]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:3.97.99.32/31]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[3.97.99.32:from]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; DMARC_BAD_POLICY(0.00)[cschubert.com : p tag has invalid value: quarantine rua=mailto:p[ostmaster@cschubert.com]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-main@freebsd.org,dev-commits-ports-all@freebsd.org]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[] X-Spamd-Bar: - X-Rspamd-Queue-Id: 4YWg2d6CN8z58yY In message <202501112057.50BKvD38009217@gitrepo.freebsd.org>, Larry Rosenman wr ites: > The branch main has been updated by ler: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=0654456e061181e74fd0eb06f9b966 > a4e759769d > > commit 0654456e061181e74fd0eb06f9b966a4e759769d > Author: Larry Rosenman > AuthorDate: 2025-01-11 20:51:00 +0000 > Commit: Larry Rosenman > CommitDate: 2025-01-11 20:51:00 +0000 > > sysutils/lsof: fix breakage after 3a0cdb2675e6 > > - put /usr/src first. > --- > sysutils/lsof/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sysutils/lsof/Makefile b/sysutils/lsof/Makefile > index f65273c5c932..a10d7db4320a 100644 > --- a/sysutils/lsof/Makefile > +++ b/sysutils/lsof/Makefile > @@ -3,6 +3,7 @@ > > PORTNAME= lsof > DISTVERSION= 4.99.4 > +PORTREVISION= 1 > PORTEPOCH= 8 > CATEGORIES= sysutils > > @@ -40,7 +41,7 @@ BOOKE_CFLAGS= -DBOOKE > CONFIGURE_SCRIPT= Configure > CONFIGURE_ARGS= -n freebsd > CONFIGURE_ENV= FREEBSD_SYS="${SRC_BASE}/sys" \ > - LSOF_CC="${CC}" > + LSOF_CC="${CC} -idirafter /usr/src" This is wrong. If /usr/src is updated, i.e. git pull, but not installed, i.e. installworld, header files and libraries may be mismatched. Note: The follow-on 1ec769ae9a64 perpetuates this wrong-ness. > BUILD_DEPENDS= ${LOCALBASE}/bin/bash:shells/bash > > # GCC needs -lzfs -lzpool for reasons unknown. If someone can > -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0