From owner-freebsd-hackers@freebsd.org Thu Sep 15 19:16:45 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6F9A1BDB1BD for ; Thu, 15 Sep 2016 19:16:45 +0000 (UTC) (envelope-from kaduk@mit.edu) Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu [18.9.25.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 220B48E8 for ; Thu, 15 Sep 2016 19:16:44 +0000 (UTC) (envelope-from kaduk@mit.edu) X-AuditID: 1209190f-383ff7000000227b-5e-57daf3944135 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id E9.A7.08827.493FAD75; Thu, 15 Sep 2016 15:16:37 -0400 (EDT) Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id u8FJGadH003315; Thu, 15 Sep 2016 15:16:36 -0400 Received: from multics.mit.edu (system-low-sipb.mit.edu [18.187.2.37]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id u8FJGXaD025346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 15 Sep 2016 15:16:35 -0400 Received: (from kaduk@localhost) by multics.mit.edu (8.12.9.20060308) id u8FJGWoi009168; Thu, 15 Sep 2016 15:16:32 -0400 (EDT) Date: Thu, 15 Sep 2016 15:16:32 -0400 (EDT) From: Benjamin Kaduk To: Daniil Berendeev cc: freebsd-hackers@FreeBSD.org Subject: Re: Multiple possible null-pointer dereferences In-Reply-To: <614a3aa7-a903-23f5-33b8-c367f22cd454@openmailbox.org> Message-ID: References: <614a3aa7-a903-23f5-33b8-c367f22cd454@openmailbox.org> User-Agent: Alpine 1.10 (GSO 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsUixG6nrjv1861wg3ffGC22b/7HaHHjwgw2 ByaPGZ/ms3i8ObGULYApissmJTUnsyy1SN8ugSvj0MKDTAXbWCpeb1/N3MC4i7mLkZNDQsBE Ytv9PUA2F4eQQBuTxPTOk6wQzkZGieUnm5kgnENMEtdvzmCDcBoYJbZdngiU4eBgEdCW2Lvc C2QUm4CKxMw3G9lAbBEBQ4mnr+8wgdjMAvISZ8/dZAGxhQUsJC59OgFmcwo4S0zf/gbsDF4B B4mlm9eygthCAk4S3+5tBYuLCuhIrN4/hQWiRlDi5MwnLBAztSSWT9/GMoFRYBaS1CwkqQWM TKsYZVNyq3RzEzNzilOTdYuTE/PyUot0TfRyM0v0UlNKNzGCQpJTkn8H45wG70OMAhyMSjy8 AbNvhQuxJpYVV+YeYpTkYFIS5eXZBRTiS8pPqcxILM6ILyrNSS0+xCjBwawkwtv+CSjHm5JY WZValA+TkuZgURLn7ZpxIFxIID2xJDU7NbUgtQgmK8PBoSTBGw3SKFiUmp5akZaZU4KQZuLg BBnOAzQ8FGx4cUFibnFmOkT+FKMux4Ift9cyCbHk5eelSonzbgQpEgApyijNg5sDTiW7mVRf MYoDvSUMMYoHmIbgJr0CWsIEtGTLmusgS0oSEVJSDYxbw3Ny5U7uOBiZ8Mrp6yGf4OmMuxav Ufx3fm3Ohr7EO4uqPZYY7+z3lgnRnGEU8vuJmfVriS6mpUVSR1fVX5LeatywouBxgUVZS0qb X6+IStmhrd4JbKw3ChLMblat7FdI7RFeMENoWc75rTv2nj9m+HTFh5X3zRdfnWhe9egNz5cb 93ZJhDIqsRRnJBpqMRcVJwIAqcmgmgADAAA= X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2016 19:16:45 -0000 On Thu, 15 Sep 2016, Daniil Berendeev wrote: > Hello, its cppcheck guy again. > > I'm digging through error messages, and there are lots of them related > to null pointer dereferences. But I'm not sure if those should be > considered as bugs and fixed. Maybe I'm missing a point? I only looked at the first one, but it looks like a bug. But, all the pasted examples looked like they were or were likely to be in contrib code, so fixing them is more tedious, as it has to go through the upstream code owner and then get imported into FreeBSD. -Ben