From owner-freebsd-ports-bugs@freebsd.org Thu Apr 18 16:47:36 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1AB97157634A for ; Thu, 18 Apr 2019 16:47:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 921726E832 for ; Thu, 18 Apr 2019 16:47:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5007E1576349; Thu, 18 Apr 2019 16:47:35 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 294F61576348 for ; Thu, 18 Apr 2019 16:47:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A6A3B6E830 for ; Thu, 18 Apr 2019 16:47:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id B5C40D766 for ; Thu, 18 Apr 2019 16:47:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x3IGlXrf093469 for ; Thu, 18 Apr 2019 16:47:33 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x3IGlXgf093468 for ports-bugs@FreeBSD.org; Thu, 18 Apr 2019 16:47:33 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 237352] [NEW PORT] databases/mongodb40-tools: Tools for MongoDB Date: Thu, 18 Apr 2019 16:47:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 16:47:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237352 --- Comment #3 from Tobias Kortkamp --- Comment on attachment 203756 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D203756 mongodb40-tools.patch +USES=3D compiler:c++14-lang localbase go Why add USES=3Dgo if you provide your own do-build, do-install? It basically doesn't do much anymore after that. ;-) +CC=3D clang Why? +SSL_USE=3D my_tags=3Dssl +SSL_USES=3D ssl + +SASL_USE=3D my_tags=3Dsasl +SASL_LIB_DEPENDS=3D libsasl2.so:security/cyrus-sasl2 Please put these with the rest of the options helpers below. +GO_LANG_VERSION=3D 1.4 +GO_LANG_VER_PATH_STR=3D ${GO_LANG_VERSION:S/.//} This seems needlessly complicated to me. lang/go14 should only be used to bootstrap lang/go and not by individual ports. Doesn't this build with lang/go? +BUILD_DEPENDS=3D=20=20=20=20=20=20=20=20 go>=3D${GO_LANG_VERSION}:lang/go${GO_LANG_VERSION_PATH_STR} This is wrong. It looks for a package named 'go' which only lang/go provides. The package name for lang/go14 is 'go14' and it never provides a 'go' package. However USES=3Dgo adds a correct BUILD_DEPENDS so the framework never complains. +MAKE_CMD=3D ${LOCALBASE}/go${GO_LANG_VER_PATH_STR}/bin/go build Please do not overwrite MAKE_CMD like this. It might make sense if the port provides its own do-build, do-install but this is not the case here. AFAICT it's only used in do-build here, so just put the 'go build' command directly in there. +MY_TAGS=3D -tags "${USE_MY_TAGS}" MY_TAGS is only used in do-install, so this could be placed directly in it instead of defining it. +.for TOOL in ${TOOL_BUILD} +.for DOC in README.md CONTRIBUTING.md LICENSE.md THIRD-PARTY-NOTICES Use lower case chars for loop variables. +post-install: +.for TOOL in ${TOOL_BUILD} + @${ECHO_MSG} "Stripping ${TOOL}" + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/${TOOL} +.endfor This should be part of do-install. post-install is only useful if the framework default do-install is used, but this is not the case here. However ${INSTALL_PROGRAM} already strips binaries so this is probably not needed at all. --=20 You are receiving this mail because: You are the assignee for the bug.=