Date: Thu, 18 Apr 2019 16:47:33 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 237352] [NEW PORT] databases/mongodb40-tools: Tools for MongoDB Message-ID: <bug-237352-7788-wttHgFqa2P@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-237352-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-237352-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237352 --- Comment #3 from Tobias Kortkamp <tobik@freebsd.org> --- Comment on attachment 203756 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D203756 mongodb40-tools.patch +USES=3D compiler:c++14-lang localbase go Why add USES=3Dgo if you provide your own do-build, do-install? It basically doesn't do much anymore after that. ;-) +CC=3D clang Why? +SSL_USE=3D my_tags=3Dssl +SSL_USES=3D ssl + +SASL_USE=3D my_tags=3Dsasl +SASL_LIB_DEPENDS=3D libsasl2.so:security/cyrus-sasl2 Please put these with the rest of the options helpers below. +GO_LANG_VERSION=3D 1.4 +GO_LANG_VER_PATH_STR=3D ${GO_LANG_VERSION:S/.//} This seems needlessly complicated to me. lang/go14 should only be used to bootstrap lang/go and not by individual ports. Doesn't this build with lang/go? +BUILD_DEPENDS=3D=20=20=20=20=20=20=20=20 go>=3D${GO_LANG_VERSION}:lang/go${GO_LANG_VERSION_PATH_STR} This is wrong. It looks for a package named 'go' which only lang/go provides. The package name for lang/go14 is 'go14' and it never provides a 'go' package. However USES=3Dgo adds a correct BUILD_DEPENDS so the framework never complains. +MAKE_CMD=3D ${LOCALBASE}/go${GO_LANG_VER_PATH_STR}/bin/go build Please do not overwrite MAKE_CMD like this. It might make sense if the port provides its own do-build, do-install but this is not the case here. AFAICT it's only used in do-build here, so just put the 'go build' command directly in there. +MY_TAGS=3D -tags "${USE_MY_TAGS}" MY_TAGS is only used in do-install, so this could be placed directly in it instead of defining it. +.for TOOL in ${TOOL_BUILD} +.for DOC in README.md CONTRIBUTING.md LICENSE.md THIRD-PARTY-NOTICES Use lower case chars for loop variables. +post-install: +.for TOOL in ${TOOL_BUILD} + @${ECHO_MSG} "Stripping ${TOOL}" + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/${TOOL} +.endfor This should be part of do-install. post-install is only useful if the framework default do-install is used, but this is not the case here. However ${INSTALL_PROGRAM} already strips binaries so this is probably not needed at all. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-237352-7788-wttHgFqa2P>