From nobody Tue Jun 9 19:20:07 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gZdyw1lHhz6gVdm for ; Tue, 09 Jun 2026 19:20:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gZdyv3MQSz3Qtf for ; Tue, 09 Jun 2026 19:20:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781032807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Bk40n8d92/sY2FrT8VY0MndABc4pZqeDr8IwQa78Ag8=; b=aus2T8fT9XGNIZaFh7QCrykFuZcMSgzt53oaOu2rBT3YSO++o0HpdLwFu0lmb5wb54LRpc xsv9M18V6UoeSAtxuCpeooOKWsNl3o/BURETn1QbmW508rO+ZJ9CxAHHiYYKDmDoE9sPt4 YUmy73nrBv5JftyhWBAbWFHanrPceR2YghdcOQyOMQZVo7kC/HHJnHyPsXngYAk7hH08UD m/S7iKW+nsTo9hjDs/KpFV5Oyw8Dsdyq2UasgRo/rYa/enzrP5Wi8M5OHZ51VIhvutFsgi yynNL5gpJHdGcj9U0yilOxV0IRObKnrmupwWXanyMCDaxDEp0t9GPBAJ+kZA4Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781032807; a=rsa-sha256; cv=none; b=fbZnDwwNXlzWoTgbIOXBRURW1quu8isL7Ij0JaySW2FTGah9Yrst3Zq1XYyIN4BUz5Kwet gf+t4/oYo3NTCuCsWYDr5WT8MZbG20IRm2/EesyErgTe8RdG+VFsWfPpj+L3UOaFjnWK8S qY42Q3nKP7E5kk+r/3WZNG9OM6unB/fss4bFH3pCT8vi++FibZTLY9PtqpowIXF/vixmdx hrNXN4h5PQxC3GOZywP4P2RNpJxg+XaxTmj6NERAou894eHlSOQt6C/NNm7iNjKdAtLrPA V/qllaC8xGeL+h7QywxMwlk32Y84wyFMnH8pxLE69skngE3HtTysYkcsJVCqBA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781032807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Bk40n8d92/sY2FrT8VY0MndABc4pZqeDr8IwQa78Ag8=; b=QJMfiS6+5YdrqY51sQFdF5mXBEeVKul+rdAto5ZgZYXazFy+9i96EXPGA67iIRzQesCxgJ L/+jXFHrSn2hD+H8kvjSqhKOjBQiITXRWfwkQM/uRu9oJ/zIDcYP3PG/yDH85uNyAKM6c+ Muk85jz4lqObveXlrDtOp514bQWYG4e49oNKIaJuxeBP1O1GtZqDSatM5EE/gOcNe94w6L iSe0ZE3e6iQIENnYNMRbro2S/2WZM+jmdkvlYUnh4x1gtU5Duo90PhqffIkvxkk1GvNmYH ayCrlkkFnOgfHinyq0NPmZCg/8xsXMP+6JA82qhh3mGYUqQD/y/iNga7AG2r0w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gZdyv2fjSznGG for ; Tue, 09 Jun 2026 19:20:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e86f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 09 Jun 2026 19:20:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Christos Margiolis From: Mark Johnston Subject: git: 513db24414f0 - releng/15.1 - sound: Check for offset overflow in dsp_mmap_single() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.1 X-Git-Reftype: branch X-Git-Commit: 513db24414f0eae90c280b480b4453e9e4f04714 Auto-Submitted: auto-generated Date: Tue, 09 Jun 2026 19:20:07 +0000 Message-Id: <6a286767.3e86f.3961bd12@gitrepo.freebsd.org> The branch releng/15.1 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=513db24414f0eae90c280b480b4453e9e4f04714 commit 513db24414f0eae90c280b480b4453e9e4f04714 Author: Christos Margiolis AuthorDate: 2026-05-27 15:50:33 +0000 Commit: Mark Johnston CommitDate: 2026-06-09 02:59:28 +0000 sound: Check for offset overflow in dsp_mmap_single() Approved by: re (cperciva) Approved by: so Security: FreeBSD-SA-26:27.sound Security: CVE-2026-45258 Reviewed by: markj Sponsored by: The FreeBSD Foundation --- sys/dev/sound/pcm/dsp.c | 3 +++ tests/sys/sound/Makefile | 1 + tests/sys/sound/mmap.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+) diff --git a/sys/dev/sound/pcm/dsp.c b/sys/dev/sound/pcm/dsp.c index 797bfba81023..23b76ab4afac 100644 --- a/sys/dev/sound/pcm/dsp.c +++ b/sys/dev/sound/pcm/dsp.c @@ -1922,6 +1922,9 @@ dsp_mmap_single(struct cdev *i_dev, vm_ooffset_t *offset, struct pcm_channel *wrch, *rdch, *c; int err; + if (*offset >= *offset + size) + return (EINVAL); + /* * Reject PROT_EXEC by default. It just doesn't makes sense. * Unfortunately, we have to give up this one due to linux_mmap diff --git a/tests/sys/sound/Makefile b/tests/sys/sound/Makefile index ab52a7aad386..f534a8cb17e5 100644 --- a/tests/sys/sound/Makefile +++ b/tests/sys/sound/Makefile @@ -2,6 +2,7 @@ PACKAGE= tests TESTSDIR= ${TESTSBASE}/sys/sound +ATF_TESTS_C+= mmap ATF_TESTS_C+= pcm_read_write ATF_TESTS_C+= polling ATF_TESTS_C+= sndstat diff --git a/tests/sys/sound/mmap.c b/tests/sys/sound/mmap.c new file mode 100644 index 000000000000..53594b7cc962 --- /dev/null +++ b/tests/sys/sound/mmap.c @@ -0,0 +1,51 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright (c) 2026 The FreeBSD Foundation + */ + +#include +#include + +#include +#include +#include +#include + +#define FMT_ERR(s) s ": %s", strerror(errno) + +ATF_TC(mmap_offset_overflow); +ATF_TC_HEAD(mmap_offset_overflow, tc) +{ + atf_tc_set_md_var(tc, "descr", "mmap offset overflow test"); + atf_tc_set_md_var(tc, "require.kmods", "snd_dummy"); +} + +ATF_TC_BODY(mmap_offset_overflow, tc) +{ + uint8_t *buf; + off_t off; + size_t len; + int fd; + + fd = open("/dev/dsp.dummy", O_RDWR); + ATF_REQUIRE_MSG(fd >= 0, FMT_ERR("open")); + + /* off + len will overflow and wrap back to 0. */ + off = 0xfffffffffffff000; + len = 0x1000; + + buf = mmap(NULL, len, PROT_READ | PROT_WRITE, MAP_SHARED, fd, off); + ATF_REQUIRE_MSG(buf == MAP_FAILED, FMT_ERR("mmap")); + + munmap(buf, len); + + close(fd); +} + +ATF_TP_ADD_TCS(tp) +{ + ATF_TP_ADD_TC(tp, mmap_offset_overflow); + + return (atf_no_error()); +}