Date: Wed, 5 Dec 2012 01:28:42 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Chris Rees <utisoft@gmail.com> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Eitan Adler <eadler@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r308260 - head/net-mgmt/p5-Net-IP Message-ID: <20121205012842.GB45591@FreeBSD.org> In-Reply-To: <CADLo83-P5rrRr=9GEOMi7km=HiZzd5KLXJygOToMah54h5mdgg@mail.gmail.com> References: <201212041815.qB4IFB55053423@svn.freebsd.org> <CADLo83-P5rrRr=9GEOMi7km=HiZzd5KLXJygOToMah54h5mdgg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 04, 2012 at 06:54:18PM +0000, Chris Rees wrote:
> On 4 Dec 2012 18:15, "Eitan Adler" <eadler@freebsd.org> wrote:
> > post-patch:
> > - @${CP} ${WRKSRC}/IP.pm ${WRKSRC}/IP.pm.presed
> > - @${SED} -e "1853s#\\s+#\s*#g" ${WRKSRC}/IP.pm.presed > \
> > - ${WRKSRC}/IP.pm
> > - @${CP} ${WRKSRC}/ipcount ${WRKSRC}/ipcount.presed
> > - @${SED} -e "76s#count#count = 0#" ${WRKSRC}/ipcount.presed > \
> > - ${WRKSRC}/ipcount
> > + ${REINPLACE_CMD} "1853s#\\s+#\s*#g" ${WRKSRC}/IP.pm
> > + ${REINPLACE_CMD} "76s#count#count = 0#" ${WRKSRC}/ipcount
>
> These are horrible- why not patches?
There *were* horrible; now they are pretty much clear and trivial. While it
is largely the matter of taste, I also prefer to perform simple mechanical
changes with sed(1) and use patches for some more complicated logic.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121205012842.GB45591>