From owner-svn-ports-all@FreeBSD.ORG  Wed Dec  5 01:28:42 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 214A96AA; Wed,  5 Dec 2012 01:28:42 +0000 (UTC)
Date: Wed, 5 Dec 2012 01:28:42 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Chris Rees <utisoft@gmail.com>
Subject: Re: svn commit: r308260 - head/net-mgmt/p5-Net-IP
Message-ID: <20121205012842.GB45591@FreeBSD.org>
References: <201212041815.qB4IFB55053423@svn.freebsd.org>
 <CADLo83-P5rrRr=9GEOMi7km=HiZzd5KLXJygOToMah54h5mdgg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <CADLo83-P5rrRr=9GEOMi7km=HiZzd5KLXJygOToMah54h5mdgg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Eitan Adler <eadler@freebsd.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Dec 2012 01:28:42 -0000

On Tue, Dec 04, 2012 at 06:54:18PM +0000, Chris Rees wrote:
> On 4 Dec 2012 18:15, "Eitan Adler" <eadler@freebsd.org> wrote:
> >  post-patch:
> > -       @${CP} ${WRKSRC}/IP.pm ${WRKSRC}/IP.pm.presed
> > -       @${SED} -e "1853s#\\s+#\s*#g" ${WRKSRC}/IP.pm.presed > \
> > -               ${WRKSRC}/IP.pm
> > -       @${CP} ${WRKSRC}/ipcount ${WRKSRC}/ipcount.presed
> > -       @${SED} -e "76s#count#count   = 0#" ${WRKSRC}/ipcount.presed > \
> > -               ${WRKSRC}/ipcount
> > +       ${REINPLACE_CMD} "1853s#\\s+#\s*#g" ${WRKSRC}/IP.pm
> > +       ${REINPLACE_CMD} "76s#count#count   = 0#" ${WRKSRC}/ipcount
> 
> These are horrible- why not patches?

There *were* horrible; now they are pretty much clear and trivial.  While it
is largely the matter of taste, I also prefer to perform simple mechanical
changes with sed(1) and use patches for some more complicated logic.

./danfe