From owner-freebsd-current@FreeBSD.ORG  Wed Mar 24 14:53:21 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 95FC416A4CE
	for <freebsd-current@freebsd.org>;
	Wed, 24 Mar 2004 14:53:21 -0800 (PST)
Received: from darkness.comp.waw.pl (unknown [195.117.238.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B789C43D45
	for <freebsd-current@freebsd.org>;
	Wed, 24 Mar 2004 14:53:20 -0800 (PST)
	(envelope-from pjd@darkness.comp.waw.pl)
Received: by darkness.comp.waw.pl (Postfix, from userid 1009)
	id D3528ACAE3; Wed, 24 Mar 2004 23:53:18 +0100 (CET)
Date: Wed, 24 Mar 2004 23:53:18 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Rafal Skoczylas <nils@secprog.org>
Message-ID: <20040324225318.GS8930@darkness.comp.waw.pl>
References: <20040323223020.GA2931@secprog.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="I2AcQh+/kfs26T/w"
Content-Disposition: inline
In-Reply-To: <20040323223020.GA2931@secprog.org>
User-Agent: Mutt/1.4.2i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 5.2.1-RC2 i386
cc: freebsd-current@freebsd.org
Subject: Re: [UFS] Broken suiddir? (+patch)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Mar 2004 22:53:21 -0000


--I2AcQh+/kfs26T/w
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 23, 2004 at 11:30:20PM +0100, Rafal Skoczylas wrote:
+> root@hawaje:/usr/src/sys/ufs/ufs% diff -u ufs_vnops.c.orig ufs_vnops.c
+> --- ufs_vnops.c.orig    Sat Oct 18 16:10:27 2003
+> +++ ufs_vnops.c Sun Mar 21 01:31:04 2004
+> @@ -1411,7 +1411,7 @@
+>                                  * our context so a stack variable is ok.
+>                                  */
+>                                 ucred.cr_ref =3D 1;
+> -                               ucred.cr_uid =3D ip->i_uid;
+> +                               ucred.cr_uid =3D dp->i_uid;
+>                                 ucred.cr_ngroups =3D 1;
+>                                 ucred.cr_groups[0] =3D dp->i_gid;
+>                                 ucp =3D &ucred;
+> root@hawaje:/usr/src/sys/ufs/ufs%

I haven't test your report and patch yet, but it is strange.
In line 1403 stays:

	ip->i_uid =3D dp->i_uid;

So ip->i_uid should be equal in line which you have patched.

--=20
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd@FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

--I2AcQh+/kfs26T/w
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAYhFeForvXbEpPzQRAjDCAKCCSbN5bguG9TN3TYz8txyjoARc4ACgiMfK
3kDKfpoAT6e2+f3beZVBZbY=
=GCq/
-----END PGP SIGNATURE-----

--I2AcQh+/kfs26T/w--