From owner-freebsd-current Tue Apr 4 08:22:43 1995 Return-Path: current-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id IAA14222 for current-outgoing; Tue, 4 Apr 1995 08:22:43 -0700 Received: from linc.cis.upenn.edu (root@LINC.CIS.UPENN.EDU [158.130.12.3]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id IAA14208; Tue, 4 Apr 1995 08:21:18 -0700 Received: from aurora.cis.upenn.edu (AURORA.CIS.UPENN.EDU [158.130.6.3]) by linc.cis.upenn.edu (8.6.10/UPenn 1.4) with SMTP id LAA10494; Tue, 4 Apr 1995 11:20:54 -0400 Posted-Date: Tue, 4 Apr 1995 11:20:48 -0400 (EDT) Date: Tue, 4 Apr 1995 11:20:48 -0400 (EDT) From: "William A. Arbaugh" To: Paul Traina Cc: jkh@FreeBSD.org, phk@FreeBSD.org, current@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: READ BEFORE SUPPING: critical change to login/su In-Reply-To: Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: current-owner@FreeBSD.org Precedence: bulk On Tue, 4 Apr 1995, Paul Traina wrote: > Apparently, the linker does not resolve undefined symbols of shared libraries > at link time, and libskey.so.2.0 makes references to stuff found in libmd.a. > The modules in libmd.a that skey requires were not getting linked into the > actual programs that used skey, so when someone actually invoked skey based > programs like keyinit(1) there were unresolved runtime references > (bloody amazing this wasn't caught earlier). > I reported it last week to hackers. Would bugs or current been more appropriate? > Anyway, the "proper" fix here is to do away with libskey.so.2.0, as it's > really not a good idea for the skey stuff to be shared anyway, which means > that libskey.a and libmd.a will be linked in the old fashioned way and > the right things will happen. > Shouldn't the linker be fixed to handle the unresolved symbols from a shared library. I agree that skey shouldn't be a shared library, but that really isn't fixing the real problem though. Someone may stumble onto this again with another program that uses a mix of shared and static libraries. bill ----------------------------------------------------------------------- Bill Arbaugh email: waa@aurora.cis.upenn.edu office: Moore 102 phone: (215) 573-3639 FAX: (215) 573-2232 ------------------------------------------------------------------------