From owner-cvs-all Tue Jan 21 17:29:58 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B07137B401 for ; Tue, 21 Jan 2003 17:29:56 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id EF66443ED8 for ; Tue, 21 Jan 2003 17:29:50 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 67213 invoked by uid 1000); 22 Jan 2003 01:29:47 -0000 Date: Tue, 21 Jan 2003 17:29:47 -0800 (PST) From: Nate Lawson To: Bruce Evans Cc: Alfred Perlstein , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.c src/sys/alpha/osf1 imgact_osf1.c osf1_misc.c src/sys/cam cam_periph.c cam_sim.c cam_xpt.c src/sys/cam/scsi scsi_cd.c scsi_ch.c scsi In-Reply-To: <20030122100003.K30758-100000@gamplex.bde.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 22 Jan 2003, Bruce Evans wrote: > > On Tue, 21 Jan 2003, Alfred Perlstein wrote: > > > Log: > > > Remove M_TRYWAIT/M_WAITOK/M_WAIT. Callers should use 0. > > > Merge M_NOWAIT/M_DONTWAIT into a single flag M_NOWAIT. > > Robert Watson wrote: > > Hmm. I guess I missed the discussion; I'm a bit behind on mailing lists. > > To improve code portability and careful thinking by developers, what I'd > > like to see is something more like the following: M_WAITOK, which > > explicitly requests sleeping indefinitely, M_NOWAIT, which explicitly > > requests no sleeping. Rather than a "default" value, a > > That's exactly what M_WAITOK was supposed to do. Developers just had to > think about it since it wasn't really a flag so it was not easy to check > automatically. I like Robert's approach -- keep the flags as they were before but give M_WAITOK a value other than 0 and deprecate passing in 0 as an arg. This change only would affect binary kld compat and if 0 only generated a printf warning (one-shot) but still meant M_WAITOK for a little while, that would ease the migration. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message