From nobody Sun Apr 21 07:39:11 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VMgHg1V0nz5Hj5s for ; Sun, 21 Apr 2024 07:39:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VMgHg02lzz4dnF for ; Sun, 21 Apr 2024 07:39:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713685151; a=rsa-sha256; cv=none; b=pvHP9APhqdxNLAaK3ObKLWL3V4sdL/8GptpIKHNNuvJGtYPAjlfMefISvKMauuweMmzSHr 3+7+WD4qgjcPOucsm4q5j80JDGlth6FYjeiYHwiLMFz23wiT2vi7o9pDwNJZvkFVEU8tGD VJP4DjT+K3YBwZ0S6cNoVVEf+P97o1rG8FHiUB7ivTNlssDF5YIMqbqH9TR//Qu8ZJJl9Q oSg2Aesz5NHKm0SYzLyk8X+q1TGY1ILwQfpqfcBgA/xS/ftJjCL9VVI5Ncjb+LN/SzwnEt r0baV9WwO7eOsNmz7FkqKC7LnRWDvfnh1V+Hnh5cqGLRPwsGB7f7FaxXbXK43A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713685151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c/+Lmmq6D8MPUdpl7Hssmf9LfQw62wtv2BlbnlQTdwI=; b=CIDqqeZGXfr9zaTO1hHx62HsBsk6BvLLne8CvIFMXfjwUBUgn8J7r91ptlGeyZVEEUDEeu Vebl2Bzo3CsvqG6o85Pi9RdECmXS7DP5oVXpqHNm2zxRCf53IsNXvlaMRRPyj228YISsvl YcSKmdhZEv7xbqFtwT7kuMhNLblVlYOsSLGZK6XxhkvIk5JYF6DrGw9pNd4HYIamE6sORQ qQ48Ru9vcdk0gBmOT2Fbm8aE3YgclbVaUFnb8lZFluV50TlDpj5mn9d4RgTXgZX7ePDW0Z Q+lGzO5I6Dx1qJjXAbCEm5Ygm6jsEHgIVOXaAOlymYKi2n1ffF5BlcXsElZpiw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VMgHf6fQ2z19tv for ; Sun, 21 Apr 2024 07:39:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 43L7dAZj078177 for ; Sun, 21 Apr 2024 07:39:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 43L7dAKH078172 for fs@FreeBSD.org; Sun, 21 Apr 2024 07:39:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 278494] Hang during boot after recent ZFS update in CURRENT Date: Sun, 21 Apr 2024 07:39:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kyle@ambroffkao.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D278494 --- Comment #6 from Kyle Ambroff-Kao --- I think I see the bug. Note that this comment says that it skips handling faults on device open *or flush*, but it is checking for IOCTL not FLUSH in that if condition. --- a/module/zfs/zio_inject.c +++ b/module/zfs/zio_inject.c @@ -364,10 +364,10 @@ zio_handle_device_injection_impl(vdev_t *vd, zio_t *z= io, int err1, int err2) int ret =3D 0; /* - * We skip over faults in the labels unless it's during - * device open (i.e. zio =3D=3D NULL). + * We skip over faults in the labels unless it's during device open + * (i.e. zio =3D=3D NULL) or a device flush (offset is meaningless) */ - if (zio !=3D NULL) { + if (zio !=3D NULL && zio->io_type !=3D ZIO_TYPE_IOCTL) { uint64_t offset =3D zio->io_offset; if (offset < VDEV_LABEL_START_SIZE || This is changed upstream in a later change https://github.com/openzfs/zfs/commit/d7605ae77b7ad176e8dbd5649fe4d14f5f4e8= b9f I'll confirm that this is the issue. --=20 You are receiving this mail because: You are the assignee for the bug.=