Date: Thu, 3 Mar 2016 13:46:51 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296320 - in head/sys: kern sys Message-ID: <56D8323B.8070407@selasky.org> In-Reply-To: <20160303124138.GS67250@kib.kiev.ua> References: <201603021846.u22IkHWM010861@repo.freebsd.org> <56D82E45.3090205@selasky.org> <20160303124138.GS67250@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/03/16 13:41, Konstantin Belousov wrote: >> The "td_slpcallout" is not drained anywhere, last time I checked. Does >> >this change require draining of the td_slpcallout in case the thread >> >immediately is exited/destroyed? > callout_stop_safe(CS_MIGRBLOCK) is enough in this case. td_slpcallout > is only reset from the sleepq code, and the fragment you cited is enough > to guarantee that no spurious wakeup of the unrelated time-bound sleep > happens, because TDF_TIMOFAIL flag cannot be cleared after that. > > Struct thread memory is type-stable, so callout subsystem never operates > on the freed memory from td_slpcallout. > > Thank you. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56D8323B.8070407>