From nobody Thu Mar 26 05:42:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fhCNC3BXtz6WDgf for ; Thu, 26 Mar 2026 05:42:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fhCNB6dXvz3YTP for ; Thu, 26 Mar 2026 05:42:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774503754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Op/PIPu3FDWcijhUgrWKs+ACeXaPqFtA9cYi5nAvwjA=; b=M3mfPsDnV/1bUpeb721bKj0TNTBVgJ/ZZDXX1FiMozwk5tGnBuRC3kqBEslbL/oM8vSSFn KPta7TL3fypzaKnT1lYEHwvIDtmKWFYfPFRUw9RvkAZCs2ICtaEJmVFz8A512HGqe1kzXM yqqyyGXGg3Ov2nn3FvVvKUnhxvUzyFdypJAXGUeE3Ti1fblNR/bi0C7e8G/P9HrL0K2OyJ VxZGUyZWx4hHFEoIvnh0/LFdYBUGw589lL1o+GMa+4efWfHKOzKqy7qRTw/h03XFBAGnhi Wxb/UcamdLDocDzRzZBAI4B+dt+RmSe/vckYYBsZXGmK8ysJzPo7YskbPG0fmw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774503754; a=rsa-sha256; cv=none; b=pfssUvcRM3wOfJNvT384YdQn71OoZIsjnMd/O5ascA5+UXKq5NWZ/0gQDXbO1uHsYjVJtZ 7v/3fd/O0pdJTh1iFh+U8oAa/CBvS354bnoZfigRLm5Uu9ZcDWvuo1GBNaM0Ik4BrI7wCQ NDKY/7N6yhhg8/ufLERRcZ3p6P2bZytjlSINMllaRCAyBM1y0yrFqUQzVYrnYGfU648hwI 6nH+oNU5JPoBj5LzFGMCAamSo/YDmsIlU8o1T0/r4dzqcVqNIFSeQnSko/TpSeAEKx9ntB vjrLUFasQGJE8WJFBLFNzrt1UkLETLCuqP1CiCXlSFRne96bWsOBsQ10qir9mg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774503754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Op/PIPu3FDWcijhUgrWKs+ACeXaPqFtA9cYi5nAvwjA=; b=dD0bygfoJHlD1LfwOh43YaKYiTDfZUBgg3Dnv8LfoiWLyZ+9IHw0G9g9W0h/AA+wxW6zSP YaD3ZuvU7NLF9jmV+IWGHiwOeDBtFzne5yolrgoVV0sgFCkN7GBpQfnIQ/wSbY1Qp3z8D0 gVZFtZqUZ8fXskMAaFSQdHgfiRKhLjFlYYYm/SBQVsOb94i7bG/vM/EV6RZi9oskcGEYbx HzNttqSqs5T6iVjEtotCYN+w2N1oH1ucUTZV+AQXZsj9NG+7SfCQkI2JLW6X4lyS8KDHdx XcvDct0yAmKuljxCXb3a2WvIHgfCHdZYiI2HHBiO8AW/6KcDj4Rz53B67/kJ0Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fhCNB5tt6zfqw for ; Thu, 26 Mar 2026 05:42:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ea6a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 26 Mar 2026 05:42:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kirk McKusick Subject: git: b0ef93ae3f63 - stable/15 - Delete error-check code that can never happen. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mckusick X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b0ef93ae3f63a31a493d00a8d9e43b411384ef51 Auto-Submitted: auto-generated Date: Thu, 26 Mar 2026 05:42:34 +0000 Message-Id: <69c4c74a.3ea6a.3f3fd193@gitrepo.freebsd.org> The branch stable/15 has been updated by mckusick: URL: https://cgit.FreeBSD.org/src/commit/?id=b0ef93ae3f63a31a493d00a8d9e43b411384ef51 commit b0ef93ae3f63a31a493d00a8d9e43b411384ef51 Author: Kirk McKusick AuthorDate: 2026-03-19 00:45:23 +0000 Commit: Kirk McKusick CommitDate: 2026-03-26 05:42:21 +0000 Delete error-check code that can never happen. Near the top of kern_mmap() that implements the mmap(2) system call, it sets prot = PROT_EXTRACT(prot); with So prot can only be the three PROT_ flags. The following test of the user's mmap(2) parameters (near line 275 in vm/vm_mmap.c): if (prot != PROT_NONE && (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC)) != 0) { return (EXTERROR(EINVAL, "invalid prot %#jx", prot)); } can never fail. This commit deletes it. No functional change intended. Reviewed by: kib Sponsored by: Netflix (cherry picked from commit 51446d33c6fbc27ce21f54ebb4c27caace48c3be) --- sys/vm/vm_mmap.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/vm/vm_mmap.c b/sys/vm/vm_mmap.c index 234586893b59..cb5906440f56 100644 --- a/sys/vm/vm_mmap.c +++ b/sys/vm/vm_mmap.c @@ -271,10 +271,6 @@ kern_mmap(struct thread *td, const struct mmap_req *mrp) return (EXTERROR(EINVAL, "both SHARED and PRIVATE set (flags %#jx)", flags)); } - if (prot != PROT_NONE && - (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC)) != 0) { - return (EXTERROR(EINVAL, "invalid prot %#jx", prot)); - } if ((flags & MAP_GUARD) != 0 && (prot != PROT_NONE || fd != -1 || pos != 0 || (flags & ~(MAP_FIXED | MAP_GUARD | MAP_EXCL | MAP_32BIT | MAP_ALIGNMENT_MASK)) != 0)) {