From owner-svn-src-head@freebsd.org Fri Apr 8 11:59:12 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 68414B08B1B; Fri, 8 Apr 2016 11:59:12 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 390A6105D; Fri, 8 Apr 2016 11:59:12 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u38BxBef097445; Fri, 8 Apr 2016 11:59:11 GMT (envelope-from avg@FreeBSD.org) Received: (from avg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u38BxBkO097444; Fri, 8 Apr 2016 11:59:11 GMT (envelope-from avg@FreeBSD.org) Message-Id: <201604081159.u38BxBkO097444@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: avg set sender to avg@FreeBSD.org using -f From: Andriy Gapon Date: Fri, 8 Apr 2016 11:59:11 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r297710 - head/sys/kern X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2016 11:59:12 -0000 Author: avg Date: Fri Apr 8 11:59:11 2016 New Revision: 297710 URL: https://svnweb.freebsd.org/changeset/base/297710 Log: topo_set_pu_id: turn a check into an assertion The new id must not be present in any cpu set in any topology element. MFC after: 30 days Modified: head/sys/kern/subr_smp.c Modified: head/sys/kern/subr_smp.c ============================================================================== --- head/sys/kern/subr_smp.c Fri Apr 8 11:58:24 2016 (r297709) +++ head/sys/kern/subr_smp.c Fri Apr 8 11:59:11 2016 (r297710) @@ -1029,8 +1029,8 @@ topo_set_pu_id(struct topo_node *node, c node->subtype = 1; while ((node = node->parent) != NULL) { - if (CPU_ISSET(id, &node->cpuset)) - break; + KASSERT(!CPU_ISSET(id, &node->cpuset), + ("logical ID %u is already set in node %p", id, node)); CPU_SET(id, &node->cpuset); node->cpu_count++; }