From owner-cvs-src@FreeBSD.ORG Fri Sep 24 19:20:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8629416A4CE; Fri, 24 Sep 2004 19:20:05 +0000 (GMT) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id A88A743D41; Fri, 24 Sep 2004 19:20:04 +0000 (GMT) (envelope-from j@uriah.heep.sax.de) Received: from sax.sax.de (localhost [127.0.0.1]) by sax.sax.de (8.12.10/8.12.10) with ESMTP id i8OJK31A008651; Fri, 24 Sep 2004 21:20:03 +0200 (CEST) (envelope-from j@uriah.heep.sax.de) Received: (from uucp@localhost) by sax.sax.de (8.12.10/8.12.10/Submit) with UUCP id i8OJK3EF008650; Fri, 24 Sep 2004 21:20:03 +0200 (CEST) (envelope-from j@uriah.heep.sax.de) Received: from uriah.heep.sax.de (localhost.heep.sax.de [127.0.0.1]) by uriah.heep.sax.de (8.12.10/8.12.10) with ESMTP id i8OJIq3R097829; Fri, 24 Sep 2004 21:18:52 +0200 (MET DST) (envelope-from j@uriah.heep.sax.de) Received: (from j@localhost) by uriah.heep.sax.de (8.12.10/8.12.10/Submit) id i8OJIqpF097828; Fri, 24 Sep 2004 21:18:52 +0200 (MET DST) (envelope-from j) Date: Fri, 24 Sep 2004 21:18:52 +0200 From: Joerg Wunsch To: Poul-Henning Kamp Message-ID: <20040924211852.A97770@uriah.heep.sax.de> References: <200409241304.i8OD4nPc029171@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200409241304.i8OD4nPc029171@repoman.freebsd.org>; from phk@FreeBSD.org on Fri, Sep 24, 2004 at 01:04:49PM +0000 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E X-GnuPG-Fingerprint: 5E84 F980 C3CA FD4B B584 1070 F48C A81B 69A8 5873 X-Spam-Status: No, hits=-4.9 required=7.5 tests=BAYES_00 autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on uriah.heep.sax.de cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fdc fdc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Joerg Wunsch List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2004 19:20:05 -0000 As Poul-Henning Kamp wrote: > Modified files: > sys/dev/fdc fdc.c > Log: > Lock the flags field with the mutex. > > Improve a number of comments. That doesn't really explain this one: @@ -96,8 +96,6 @@ * fd_drivetype; on i386 machines, if * given as 0, use RTC type for fd0 * and fd1 */ -#define FD_NO_CHLINE 0x10 /* drive does not support changeline - * aka. unit attention */ #define FD_NO_PROBE 0x20 /* don't probe drive (seek test), just * assume it is there */ No idea about why FD_NO_CHLINE got obsolete, but either way, that should also be updated in src/share/man/man4/fdc.4 as well since the 0x10 flag is documented there. What I'm also missing is a documentation of the new debug flags. Not necessarily in fdc(4) (it's useful for developers only), but at least as a comment on top of the file. (Sure, Julian's old debug output wasn't documented either, but we're here to make it better, aren't we? ;-) Shouldn't the flag manipulation in fdc_thread() also be protected by a mutex? (I currently can't really test all this as long as GEOM doesn't allow me unloading the driver...) -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)