Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 31 Aug 2006 20:37:41 +0400
From:      Ruslan Ermilov <ru@freebsd.org>
To:        Sam Leffler <sam@errno.com>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, "M. Warner Losh" <imp@bsdimp.com>
Subject:   Re: cvs commit: src/usr.bin/tip/libacu biz22.c biz31.c courier.c df.c dn11.c hayes.c t3000.c v3451.c v831.c ventel.c src/usr.bin/tip/tip Makefile acu.c acutab.c cmds.c cmdtab.c cu.c hunt.c log.c partab.c pathnames.h remote.c tip.1 tip.c tip.h tipout.c uucplock.c value.c ...
Message-ID:  <20060831163741.GJ56996@rambler-co.ru>
In-Reply-To: <44F70CD2.4020901@errno.com>
References:  <200608311414.k7VEEVkx048750@repoman.freebsd.org> <20060831144630.GC56996@rambler-co.ru> <20060831.100529.-75256320.imp@bsdimp.com> <44F70CD2.4020901@errno.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--x0KprKst+ZOYEj2z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 31, 2006 at 09:22:42AM -0700, Sam Leffler wrote:
> M. Warner Losh wrote:
> > In message: <20060831144630.GC56996@rambler-co.ru>
> >             Ruslan Ermilov <ru@freebsd.org> writes:
> > : Recently, I've found several bugs in tip(1).  I started fixing them,
> > : but then I looked at the OpenBSD, and they seemed to have all been
> > : fixed.  New import brings some visible new bugs (when compiled with
> > : WARNS=3D2 for example).  I'm going to address them as well and send
> > : patches back to OpenBSD (as well as changes made to manpages).
> >=20
> > /me too.
> >=20
> > btw, do you think it is finally time to change ^A to not mean 'go into
> > all upper case mode' by default in tip?
>=20
> That's a config parameter you've always been able to set.  I recall the
> obsd folks changed the default to so ^A was not enabled as part of their
> overhaul.
>=20
They indeed changed it, so did we (with this import):

Index: vars.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/usr.bin/tip/tip/vars.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -p -r1.6 -r1.7
[...]
@@ -82,7 +78,7 @@ value_t vtable[] =3D {
        { "raise",      BOOL,                   (READ|WRITE)<<PUBLIC,
          "ra",         (char *)FALSE },
        { "raisechar",  CHAR,                   (READ|WRITE)<<PUBLIC,
-         "rc",         (char *)CTRL('a') },
+         "rc",         NOSTR },
        { "record",     STRING|INIT|IREMOTE,    (READ|WRITE)<<PUBLIC,
          "rec",        (char *)&RE },
        { "remote",     STRING|INIT|IREMOTE,    READ<<PUBLIC,

The change just hasn't been reflected in documentation; I've just
fixed it in a manpage.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--x0KprKst+ZOYEj2z
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFE9xBVqRfpzJluFF4RAunUAJ9jce+56dXWZ1pcQuNM17FknB43egCgiQgj
eG9354+K4AG5Ywv9Mtx/GAE=
=R6oc
-----END PGP SIGNATURE-----

--x0KprKst+ZOYEj2z--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060831163741.GJ56996>