From owner-freebsd-hackers@FreeBSD.ORG Tue Mar 4 15:59:05 2008 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69584106566B; Tue, 4 Mar 2008 15:59:05 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id D180D8FC45; Tue, 4 Mar 2008 15:59:04 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from kobe.laptop (vader.bytemobile-rio.ondsl.gr [83.235.57.37]) (authenticated bits=128) by igloo.linux.gr (8.14.1/8.14.1/Debian-9) with ESMTP id m24FwcwF001619 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 4 Mar 2008 17:58:51 +0200 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.2/8.14.2) with ESMTP id m24FwRUj096554; Tue, 4 Mar 2008 17:58:27 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by kobe.laptop (8.14.2/8.14.2/Submit) id m24FwQjl096546; Tue, 4 Mar 2008 17:58:26 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Tue, 4 Mar 2008 17:58:25 +0200 From: Giorgos Keramidas To: "M. Warner Losh" Message-ID: <20080304155825.GA95950@kobe.laptop> References: <20080303.224256.635730757.imp@bsdimp.com> <20080304151326.J41184@fledge.watson.org> <20080304153730.GA61036@kobe.laptop> <20080304.085022.-1605837445.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080304.085022.-1605837445.imp@bsdimp.com> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.976, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.42, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Spam-Status: No Cc: hackers@freebsd.org, rwatson@freebsd.org Subject: Re: Comments on pmake diffs for building on Linux X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 15:59:05 -0000 On 2008-03-04 08:50, "M. Warner Losh" wrote: > In message: <20080304153730.GA61036@kobe.laptop> > Giorgos Keramidas writes: > : "arch.c", line 1063: undefined symbol: INT_MIN > : cc: acomp failed for arch.c > : *** Error code 2 > : make: Fatal error: Command failed for target `arch.o' > : Current working directory /home/keramida/bmake/src > : > : This is easy to fix with: > : > : diff -r 68bfc25ed443 src/arch.c > : --- a/src/arch.c Tue Mar 04 17:29:11 2008 +0200 > : +++ b/src/arch.c Tue Mar 04 17:35:08 2008 +0200 > : @@ -96,6 +96,7 @@ > : #include > : #include > : #include > : +#include > : #include > : #include > : #include > > We likely should just commit this to FreeBSD's make, since Section > 5.2.4.2.1 of the C standard says that INT_MIN is defined there. That's true. This is, I hope, one of the good things about the `exercise' of making BSD make build on all three of BSD, Linux and Solaris :) Should I commit the change to arch.c to HEAD? > : The next part, about the missing errx() functions on Solaris is > : going to be tonight's fun. If there are too many missing functions, > : it may be worth adding a static `libcompat' with copies of just the > : functions we need to run BSD make on non-BSD hosts. > > In the longer term, this likely is a good idea. In the shorter term, > I'm not so sure that this is a good idea, since all you'd need would > be inlines for the functions that make uses. Once everything builds I plan to keep `synchronizing' with the usr.bin/make version, so I'm willing to go the extra mile to make things more maintanable in the long run.