Date: Thu, 24 May 2007 14:44:51 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: Stephen Montgomery-Smith <stephen@math.missouri.edu> Cc: gnome@FreeBSD.org, freebsd-ports@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: More speed increases for make-ing ports Message-ID: <1180010691.66903.28.camel@pav.hide.vol.cz> In-Reply-To: <46558678.3020704@math.missouri.edu> References: <465291FB.4010901@math.missouri.edu> <20070522071941.GB59910@xor.obsecurity.org> <4652FFB4.8060107@math.missouri.edu> <1179846295.52353.27.camel@pav.hide.vol.cz> <4653349D.7080608@math.missouri.edu> <46533D66.1070305@math.missouri.edu> <1179868612.83498.6.camel@ikaros.oook.cz> <1179869940.83498.9.camel@ikaros.oook.cz> <20070522165525.S52261@math.missouri.edu> <1179871899.83498.10.camel@ikaros.oook.cz> <20070522172627.A52261@math.missouri.edu> <465398E0.40404@math.missouri.edu> <1179907804.60308.1.camel@pav.hide.vol.cz> <4654E491.5000700@math.missouri.edu> <1179995317.66903.17.camel@pav.hide.vol.cz> <46558678.3020704@math.missouri.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-tEMHSG95fNNZcIdwfSgp Content-Type: text/plain; charset=ISO8859-2 Content-Transfer-Encoding: quoted-printable Stephen Montgomery-Smith p=ED=B9e v =E8t 24. 05. 2007 v 07:35 -0500: > Pav Lucistnik wrote: > > Stephen Montgomery-Smith p=ED=B9e v st 23. 05. 2007 v 20:04 -0500: > >=20 > >> I'm getting kind of uncomfortable with the patch. I looked some more > >> in=20 > >> bsd.gnome.mk and it seems to me that the suggested patch is really=20 > >> equivalent to the patch enclosed here. > >> > >> Why did the writer of bsd.gnome.mk have the rather complicated=20 > >> construction which I am proposing to replace? > >=20 > > I don't know, we'd have to ask Joe Marcus. Here is the revision in > > question: > >=20 > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.gnome.mk.diff?r1=3D1= .22;r2=3D1.23 > >=20 > > You're basically reverting that revision. Perhaps our make(1) wasn't > > smart enough those four years ago, I don't know. >=20 > I'm not really reverting that revision. As it was prior to that=20 > revision, I can see it not working under many circumstances. Namely, if=20 > ${component} appears more than once in ${_USE_GNOME} - something that=20 > will happen frequently - the test will not work. >=20 > My revision seems the obvious way to do it to me, but I can see that if=20 > someone was working with what Joe was working with, that one could be=20 > lead to think up his revision. I know that I myself have missed the=20 > obvious in many circumstance. Please send me the patch again, as an attachment, I'll give it some workout :) --=20 Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> EMACS: Eight Megabytes And Continually Swapping --=-tEMHSG95fNNZcIdwfSgp Content-Type: application/pgp-signature; name=signature.asc Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBGVYjAntdYP8FOsoIRAm3SAKCFpvVMe9Js9q1OO3C81xu1ZpdKWgCfca8f 93FxivAwYID7Rofq75eDVyI= =cq/b -----END PGP SIGNATURE----- --=-tEMHSG95fNNZcIdwfSgp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1180010691.66903.28.camel>