From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Oct 15 07:40:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51EC8106568F for ; Thu, 15 Oct 2009 07:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 15EE18FC0C for ; Thu, 15 Oct 2009 07:40:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9F7e1GB096057 for ; Thu, 15 Oct 2009 07:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9F7e1Kj096056; Thu, 15 Oct 2009 07:40:01 GMT (envelope-from gnats) Resent-Date: Thu, 15 Oct 2009 07:40:01 GMT Resent-Message-Id: <200910150740.n9F7e1Kj096056@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Vladimir Kushnir Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EAB3F106566B for ; Thu, 15 Oct 2009 07:32:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id DA1E08FC0C for ; Thu, 15 Oct 2009 07:32:03 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n9F7W3Sp079088 for ; Thu, 15 Oct 2009 07:32:03 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n9F7W3Qs079087; Thu, 15 Oct 2009 07:32:03 GMT (envelope-from nobody) Message-Id: <200910150732.n9F7W3Qs079087@www.freebsd.org> Date: Thu, 15 Oct 2009 07:32:03 GMT From: Vladimir Kushnir To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/139633: unbreak textproc/sdcv on amd64 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2009 07:40:02 -0000 >Number: 139633 >Category: ports >Synopsis: unbreak textproc/sdcv on amd64 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Oct 15 07:40:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Vladimir Kushnir >Release: FreeBSD 9.0-CURRENT amd64 >Organization: BITP >Environment: FreeBSD kushnir1.kiev.ua 9.0-CURRENT FreeBSD 9.0-CURRENT #2: Mon Oct 5 14:12:23 EEST 2009 root@kushnir1.kiev.ua:/usr/obj/usr/src/sys/KUSHNIR amd64 >Description: Console dictionary utility textproc/sdcv is marked as unbuildable on 64-bit platforms. The only source uf breakage - comparison of guint32 and sizeof() in function std::min() (src/lib/lib.cpp, line 516). Suggested fix unbreaks build. Tested under amd64 but seems to be valid for any 64-bit arch. >How-To-Repeat: >Fix: Patch attached with submission follows: *** /usr/ports/textproc/sdcv/Makefile 2009-08-31 13:31:17.000000000 +0300 --- Makefile 2009-10-15 10:12:43.000000000 +0300 *************** *** 35,44 **** .include - .if ${ARCH} == "amd64" || ${ARCH} == "ia64" || ${ARCH} == "sparc64" - BROKEN= Doesn't build on 64-bit platforms - .endif - post-patch: @${REINPLACE_CMD} -e 's|/usr/share|${PREFIX}/share|g' \ ${WRKSRC}/doc/sdcv.1 --- 35,40 ---- *************** *** 47,52 **** --- 43,52 ---- @${REINPLACE_CMD} -e 's, getopt.h,,g' ${WRKSRC}/src/Makefile.in @${REINPLACE_CMD} -e '146 s|()|(int, char * const [], const char *)|g' \ ${WRKSRC}/src/getopt.h + .if ${ARCH} == "amd64" || ${ARCH} == "ia64" || ${ARCH} == "sparc64" + @${REINPLACE_CMD} -e '516 s|sizeof|(guint32)sizeof|g' \ + ${WRKSRC}/src/lib/lib.cpp + .endif @${REINPLACE_CMD} -e 's|/usr/share|${PREFIX}/share|g' \ ${WRKSRC}/src/sdcv.cpp @${REINPLACE_CMD} -e 's,@mandir@/uk,@mandir@,' \ >Release-Note: >Audit-Trail: >Unformatted: