From owner-cvs-all Sat Dec 29 6:35:15 2001 Delivered-To: cvs-all@freebsd.org Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by hub.freebsd.org (Postfix) with SMTP id 7779737B420; Sat, 29 Dec 2001 06:35:11 -0800 (PST) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 29 Dec 2001 14:35:10 +0000 (GMT) To: Bruce Evans Cc: "David E. O'Brien" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.sys.mk In-reply-to: Your message of "Sun, 30 Dec 2001 01:21:29 +1100." <20011230011102.L5086-100000@gamplex.bde.org> X-Request-Do: Date: Sat, 29 Dec 2001 14:35:10 +0000 From: David Malone Message-ID: <200112291435.aa83853@salmon.maths.tcd.ie> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > WARNS=4 doesn't seem to be the same as WARNS=2 used to be, because > > -Wno-uninitialized isn't getting added at the end of the warnings > > flags and so -Wuninitialized is still producing false positives. > > Could someone review the patch below? > Doesn't it work where it already is, since it is to cancel the > -Wuninitialized provied by -Wall? It doesn't seem to work - try setting WARNS=4 and then compiling usr.bin/getcat. I've just checked and it seems that -W also sets -Wuninitialised: 14:29:gonzo 29% gcc -O -W -c blah.c blah.c: In function `f': blah.c:2: warning: `i' might be used uninitialized in this function 14:29:gonzo 30% gcc -O -W -Wno-uninitialized -c blah.c 14:30:gonzo 31% cat blah.c void f() { int i; g(i); } Did the patch look OK, or is there some other way I should be doing this? David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message