Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 May 2018 06:21:59 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 228308] [NEW PORT] devel/kcov: ptrace-based coverage analyzer
Message-ID:  <bug-228308-7788-gQtHPaER5W@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-228308-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-228308-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228308

--- Comment #2 from Tobias Kortkamp <tobik@freebsd.org> ---
(In reply to Alan Somers from comment #1)
+BUILD_DEPENDS=3D binutils>=3D2.30:devel/binutils \
+               cmake:devel/cmake

cmake is redundant here because USES=3Dcmake already adds it.

+PORTVERSION=3D   35.55.20180516
[...]
+# Use a GitHub tag until version 36 gets released, whenever that might be
+USE_GITHUB=3D    yes
+GH_ACCOUNT=3D    SimonKagstrom
+GH_PROJECT=3D    kcov
+GH_TAGNAME=3D    69dfa9c

The USE_GITHUB bits should go directly below the USES=3D line.

GH_PROJECT defaults to whatever PORTNAME is set to, so it's redundant
here.

Instead of setting GH_TAGNAME and inventing your own PORTVERSION try to
follow the procedure at [1] to derive a DISTVERSION{,SUFFIX,PREFIX}
triple. Only set GH_TAGNAME and PORTVERSION if that doesn't work.

In this case just set

DISTVERSIONPREFIX=3D      v
DISTVERSION=3D    35-57
DISTVERSIONSUFFIX=3D      -g69dfa9c

and remove PORTVERSION and GH_TAGNAME.

+USES=3D          cmake:outsource shebangfix python:build

Do the build scripts work with Python 3.x? If not you might have to
restrict the Python version here i.e. python:2.7,build.

+CMAKE_ARGS+=3D   -DKCOV_INSTALL_MANDIR=3D${PREFIX}/man

s/+=3D/=3D/

+python_CMD=3D    ${PYTHON_CMD}

Redundant.

+SHEBANG_REGEX=3D '.*\.py'

SHEBANG_GLOB=3D   *.py

+PORTDOCS=3D      COPYING \
+               COPYING.externals \
+               ChangeLog

If you use PORTDOCS the port must have a DOCS option.

OPTIONS_DEFINE=3D DOCS

Assuming that COPYING contains the license it should be installed via e.g.

LICENSE_FILE=3D   ${WRKSRC}/COPYING

instead.

[1]
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile=
-distfiles.html#makefile-master_sites-github-ex5

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-228308-7788-gQtHPaER5W>