From owner-cvs-all@FreeBSD.ORG Tue Apr 12 06:18:16 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 83D0416A4CE for ; Tue, 12 Apr 2005 06:18:16 +0000 (GMT) Received: from mail.gmx.net (imap.gmx.net [213.165.64.20]) by mx1.FreeBSD.org (Postfix) with SMTP id D80BC43D5D for ; Tue, 12 Apr 2005 06:18:14 +0000 (GMT) (envelope-from michaelnottebrock@gmx.net) Received: (qmail invoked by alias); 12 Apr 2005 06:18:13 -0000 Received: from p508BB620.dip.t-dialin.net (EHLO lofi.dyndns.org) [80.139.182.32] by mail.gmx.net (mp010) with SMTP; 12 Apr 2005 08:18:13 +0200 X-Authenticated: #443188 Received: from kiste.my.domain (lofi@kiste.my.domain [192.168.8.4]) (authenticated bits=0) by lofi.dyndns.org (8.13.3/8.12.10) with ESMTP id j3C6I6Wd014450 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Tue, 12 Apr 2005 08:18:07 +0200 (CEST) (envelope-from michaelnottebrock@gmx.net) From: Michael Nottebrock To: obrien@FreeBSD.org Date: Tue, 12 Apr 2005 08:17:57 +0200 User-Agent: KMail/1.8 References: <200504110804.j3B84fNs060515@repoman.freebsd.org> <200504120603.10518.michaelnottebrock@gmx.net> <20050412055628.GA6385@dragon.NUXI.org> In-Reply-To: <20050412055628.GA6385@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2708905.TgPHC5M6cU"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200504120818.02749.michaelnottebrock@gmx.net> X-Virus-Scanned: by amavisd-new X-Y-GMX-Trusted: 0 cc: cvs-ports@FreeBSD.org cc: portmgr@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/archivers/gzip Makefile ports/archivers/ucl Makefile ports/archivers/lzop Makefile ports/archivers/cabextract Makefile ports/archivers/dact Makefile ports/archivers/star Makefile ports/archivers/arj Makefile ports/archivers/tardy ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2005 06:18:16 -0000 --nextPart2708905.TgPHC5M6cU Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday, 12. April 2005 07:56, David O'Brien wrote: > > The porter's handbook, section 5.11 has an example that uses > > MACHINE_ARCH, which is the template for a lot of MACHINE_ARCH usage in > > ports, > > I wondered how this got copied around so many times. > > > including a few places your commit missed, like bsd.gnome.mk, > > bsd.kde.mk, bsd.gnustep.mk and, most importantly, bsd.port.subdir.mk > > and bsd.port.mk itself (for setting CONFIGURE_TARGET(!)). > > I purposefully didn't touch Mk/*.mk. I have to assume the authors of > them got it right. :-) Well, you did however change ports that do nothing but mimic what bsd.ports= =2Emk=20 does (like audio/arts and x11/kdelibs3, which is why I noticed at all)...=20 Anyway: If the usage of MACHINE_ARCH for setting the build-target of=20 autoconf-generated configure scripts is indeed wrong and possibly harmful,= =20 this would affect a *very* large number of ports and your big commit would= =20 have fixed only a comparatively small number. =2D-=20 ,_, | Michael Nottebrock | lofi@freebsd.org (/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org \u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org --nextPart2708905.TgPHC5M6cU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQBCW2gaXhc68WspdLARAs5JAJ4ppX0/OtyOAHoj6ZqNfilJMMC5hwCeK83K sSd8ktCRRP03BRlLq2ONdpw= =8AyF -----END PGP SIGNATURE----- --nextPart2708905.TgPHC5M6cU--