From owner-freebsd-bugs@FreeBSD.ORG  Thu Aug 19 15:50:05 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1B848106567A
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 19 Aug 2010 15:50:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 0AEF48FC13
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 19 Aug 2010 15:50:05 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7JFo46I090015
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 19 Aug 2010 15:50:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7JFo4YO090014;
	Thu, 19 Aug 2010 15:50:04 GMT (envelope-from gnats)
Date: Thu, 19 Aug 2010 15:50:04 GMT
Message-Id: <201008191550.o7JFo4YO090014@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Janne Snabb <snabb@epipe.com>
Cc: 
Subject: Re: bin/149806: [patch] OpenBSM auditd(8) fails to expire trails if
 host defined
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Janne Snabb <snabb@epipe.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Aug 2010 15:50:05 -0000

The following reply was made to PR bin/149806; it has been noted by GNATS.

From: Janne Snabb <snabb@epipe.com>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/149806: [patch] OpenBSM auditd(8) fails to expire trails if
 host defined
Date: Thu, 19 Aug 2010 15:48:29 +0000 (UTC)

 An alternative fix would be to change the filename length check to
 the following:
 
 			if (dp->d_namlen < (FILENAME_LEN - 1) ||
 
 In that case the expiration routine would expire also trails without
 "host" part after the "host" parameter has been added to audit_control,
 and if the "host" parameter has been changed so that it has a
 different length than previously.
 
 Up to the maintainer to decide which matching method is better. 
 I would probably go with this one instead of my original patch.
 
 --
 Janne Snabb / EPIPE Communications
 snabb@epipe.com - http://epipe.com/