From owner-svn-ports-all@freebsd.org Mon Mar 4 19:24:52 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8BF5C151FF3D; Mon, 4 Mar 2019 19:24:52 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 335F783538; Mon, 4 Mar 2019 19:24:52 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 26FD388B2; Mon, 4 Mar 2019 19:24:52 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x24JOp34013443; Mon, 4 Mar 2019 19:24:51 GMT (envelope-from jbeich@FreeBSD.org) Received: (from jbeich@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x24JOpCs013442; Mon, 4 Mar 2019 19:24:51 GMT (envelope-from jbeich@FreeBSD.org) Message-Id: <201903041924.x24JOpCs013442@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jbeich set sender to jbeich@FreeBSD.org using -f From: Jan Beich Date: Mon, 4 Mar 2019 19:24:51 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r494635 - head/graphics/dspdfviewer/files X-SVN-Group: ports-head X-SVN-Commit-Author: jbeich X-SVN-Commit-Paths: head/graphics/dspdfviewer/files X-SVN-Commit-Revision: 494635 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 335F783538 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 19:24:52 -0000 Author: jbeich Date: Mon Mar 4 19:24:51 2019 New Revision: 494635 URL: https://svnweb.freebsd.org/changeset/ports/494635 Log: graphics/dspdfviewer: partially unbreak with Clang 8 ../dspdfviewer.cpp:311:48: error: empty expression statement has no effect; remove unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt] QSize newSize = window.getPreviewImageSize();; ^ PR: 236217 Approved by: portmgr blanket Added: head/graphics/dspdfviewer/files/patch-dspdfviewer.cpp (contents, props changed) Added: head/graphics/dspdfviewer/files/patch-dspdfviewer.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/graphics/dspdfviewer/files/patch-dspdfviewer.cpp Mon Mar 4 19:24:51 2019 (r494635) @@ -0,0 +1,17 @@ +Fix build with Clang 8: + +../dspdfviewer.cpp:311:48: error: empty expression statement has no effect; remove unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt] + QSize newSize = window.getPreviewImageSize();; + ^ + +--- dspdfviewer.cpp.orig 2016-09-13 13:18:47 UTC ++++ dspdfviewer.cpp +@@ -308,7 +308,7 @@ RenderingIdentifier DSPDFViewer::toRenderIdent(unsigne + + RenderingIdentifier DSPDFViewer::toThumbnailRenderIdent(unsigned int pageNumber, PDFViewerWindow& window) + { +- QSize newSize = window.getPreviewImageSize();; ++ QSize newSize = window.getPreviewImageSize(); + static QSize thumbnailSize; + if ( thumbnailSize != newSize ) { + DEBUGOUT << "Thumbnail size changed from" << thumbnailSize << "to" << newSize;