From owner-svn-src-head@freebsd.org Sat Nov 7 10:25:44 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59D94A27722; Sat, 7 Nov 2015 10:25:44 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail106.syd.optusnet.com.au (mail106.syd.optusnet.com.au [211.29.132.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1B7F61333; Sat, 7 Nov 2015 10:25:42 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id D351A3C192F; Sat, 7 Nov 2015 21:25:32 +1100 (AEDT) Date: Sat, 7 Nov 2015 21:25:32 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Svatopluk Kraus cc: "Conrad E. Meyer" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290475 - in head: share/man/man9 sys/kern sys/sys In-Reply-To: Message-ID: <20151107205927.P1514@besplex.bde.org> References: <201511070143.tA71h13k038232@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=cK4dyQqN c=1 sm=1 tr=0 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=kj9zAlcOel0A:10 a=-FrttOG-O2tG-sEUMfgA:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Nov 2015 10:25:44 -0000 On Sat, 7 Nov 2015, Svatopluk Kraus wrote: > You broke buildkernel. The following patch helps: > > diff --git a/sys/sys/sysctl.h b/sys/sys/sysctl.h > index 950e712..a34c890 100644 > --- a/sys/sys/sysctl.h > +++ b/sys/sys/sysctl.h > @@ -37,6 +37,7 @@ > #define _SYS_SYSCTL_H_ > > #include > +#include > > struct thread; > /* This adds namespace pollution. It shouldn't be needed. is standard namespace pollution in . (It has a bogus comment there describing only one thing that it is for.) This pollution is already in dnv.h, nv.h and racct.h. > @@ -949,7 +950,7 @@ extern char kern_ident[]; > /* Dynamic oid handling */ > struct sysctl_oid *sysctl_add_oid(struct sysctl_ctx_list *clist, > struct sysctl_oid_list *parent, int nbr, const char *name, int kind, > - void *arg1, intptr_t arg2, int (*handler)(SYSCTL_HANDLER_ARGS), > + void *arg1, intmax_t arg2, int (*handler)(SYSCTL_HANDLER_ARGS), > const char *fmt, const char *descr); > int sysctl_remove_name(struct sysctl_oid *parent, const char *name, int del, > int recurse); Apparently the original change wasn't tested on 32-bit arches. I put intptr_t in long ago, since it was more needed and less magic than intmax_t. This was obfuscated by moving it to and including that in various places. intmax_t is still only in which is much larger. It and uintmax_t should be together with intptr_t. That is more polluting in theory but less in practice. doesn't declare much else directly, but includes for the most important types (fixed-width ones). It mainly declares least-width and fast-width types directly. These should be used in most cases where fixed-width types are now used, especially in kernels, but their usability is shown by them almost never being used. Bruce