From owner-freebsd-emulation@FreeBSD.ORG Wed Jan 26 21:27:33 2011 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EEAC9106566B; Wed, 26 Jan 2011 21:27:33 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 550858FC17; Wed, 26 Jan 2011 21:27:32 +0000 (UTC) Received: by fxm16 with SMTP id 16so1499138fxm.13 for ; Wed, 26 Jan 2011 13:27:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:x-comment-to:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=F+M6whwBSCbr/xIyy9MZrH1ZdqNg0U6NVxl+eWO67zA=; b=sc6i6CSCb2iuFRziZqJJqxaY2GU+weeS7r9hyytLmeCDGoeARo2cP7VVvFwqrgu4AA tsFH584pNmH2bpXzJJ+ocF7mn2+u0HP8rUha2OMqEZA0Vg7OOGrlwPx1LgjtRCuv43j/ imsRQKdbX4bPz0796Wl8Zh/sdax+rS/9ojjzA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:x-comment-to:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=fSC8Y8ZwkGNswp1FYWZFuy27j/PQ3R3Mj6Xdf2DW1K/EN5icREVSpq4l75ExQnaBBv OwUkRRLlVMVaIrS7hlHRYb2ryJBvbul6s2BmJb43Km44IOGBJ6y2BRyvZ6ql3Qz/FefE IinoKU/p+k/8sJdlfW6T5YDjk+m8DvQ21Iccg= Received: by 10.223.86.16 with SMTP id q16mr14663fal.58.1296077251931; Wed, 26 Jan 2011 13:27:31 -0800 (PST) Received: from localhost ([95.69.174.185]) by mx.google.com with ESMTPS id n26sm5726584fam.37.2011.01.26.13.27.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 26 Jan 2011 13:27:29 -0800 (PST) From: Mikolaj Golub To: "Bjoern A. Zeeb" References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org> <86tygwy9p0.fsf@kopusha.home.net> <20110126091038.C3489@maildrop.int.zabbadoz.net> <86aainkbhb.fsf@zhuzha.ua1> <20110126141636.D3489@maildrop.int.zabbadoz.net> X-Comment-To: Bjoern A. Zeeb Date: Wed, 26 Jan 2011 23:27:27 +0200 In-Reply-To: <20110126141636.D3489@maildrop.int.zabbadoz.net> (Bjoern A. Zeeb's message of "Wed, 26 Jan 2011 14:18:03 +0000 (UTC)") Message-ID: <86ei7z4aps.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-emulation@freebsd.org, FreeBSD virtualization mailing list Subject: Re: VirtualBox + VIMAGE X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2011 21:27:34 -0000 On Wed, 26 Jan 2011 14:18:03 +0000 (UTC) Bjoern A. Zeeb wrote: BAZ> On Wed, 26 Jan 2011, Mikolaj Golub wrote: >> >> On Wed, 26 Jan 2011 09:15:46 +0000 (UTC) Bjoern A. Zeeb wrote: >> >> BAZ> I think you should wrap the CURVNET changes in __FreeBSD_version >> BAZ> checks so that the port, should it run elsewhere or on older FreeBSDs >> BAZ> (if it runs there) not trouble people having to patch it away. >> >> BAZ> #if defined(__FreeBSD_version) && __FreeBSD_version >= 800500 >> BAZ> #endif >> >> BAZ> might be a save bet. >> >> Thanks. Something like in the patch below? >> >> Note, I have not run this version yet. Will test it tonight or tomorrow. BAZ> Well, you will need to include as well, and that only if BAZ> you are on FreeBSD so you'll need an extra check for just that I BAZ> guess. Not sure how vbox handles the all this in their guts. The file has already had '#include ' among other includes. It just is not seen in the patch. The file is used only for FreeBSD driver so there is no need in extra check I think. I have tested this latest version of the patch. It works for me. -- Mikolaj Golub