From owner-freebsd-current@FreeBSD.ORG Tue Feb 10 21:56:51 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 04527B71 for ; Tue, 10 Feb 2015 21:56:51 +0000 (UTC) Received: from mail.grem.de (outcast.grem.de [213.239.217.27]) by mx1.freebsd.org (Postfix) with SMTP id 53577E4B for ; Tue, 10 Feb 2015 21:56:49 +0000 (UTC) Received: (qmail 97099 invoked by uid 89); 10 Feb 2015 21:56:49 -0000 Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@88.217.180.225) by mail.grem.de with ESMTPA; 10 Feb 2015 21:56:49 -0000 Date: Tue, 10 Feb 2015 22:56:48 +0100 From: Michael Gmelin To: Marcel Moolenaar Subject: Re: nagios vs w/uptime Message-ID: <20150210225648.10cda499@bsd64.grem.de> In-Reply-To: References: <54DA617A.4090309@wemm.org> <4A76A371-B573-4E62-BE78-94944963FFD0@freebsd.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; amd64-portbld-freebsd10.0) X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current Current , Peter Wemm X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 21:56:51 -0000 On Tue, 10 Feb 2015 22:24:59 +0100 Michael Gmelin wrote: >=20 >=20 >=20 > > On 10 Feb 2015, at 22:17, Michael Gmelin wrote: > >=20 > >=20 > >=20 > >=20 > >> On 10 Feb 2015, at 21:13, Marcel Moolenaar > >> wrote: > >>=20 > >> [Moving to current@] > >>=20 > >>> On Feb 10, 2015, at 11:52 AM, Peter Wemm wrote: > >>>=20 > >>> Surprises: > >>> * nagios doesn't like w / uptime anymore. libxo perhaps? > >>=20 > >> Seems most likely, although I haven=E2=80=99t seen any differences in > >> output in my (admittedly limited) testing. > >>=20 > >> In what way does Nagios not like w/uptime? > >> Any concrete errors, output or misbehavior? > >> Ideally: can you reproduce the problem? > >=20 > >=20 > > Just compared 10.1 to current, unmodified output looks the same, > > but pipelines don't work properly: > >=20 > > 10.1: > > # uptime | wc > > 1 12 68 > >=20 > > Current: > > # uptime | wc > > 0 0 0 > >=20 > > # uptime | cat > > # uptime > > 10:16PM up 9 mins... > >=20 >=20 > Adding xo_finish() to w.c line 268 just right before exit(0); fixes > that issue (I don't know libxo well enough to say if this is the > proper fix or just a workaround, but it seems logical to me). >=20 I opened a code review request: https://reviews.freebsd.org/D1821 --=20 Michael Gmelin