From owner-svn-src-head@freebsd.org Mon Mar 16 13:46:43 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B6E90266D18; Mon, 16 Mar 2020 13:46:43 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48gyJc4F2qz3Nl5; Mon, 16 Mar 2020 13:46:40 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-io1-f48.google.com with SMTP id h131so17196311iof.1; Mon, 16 Mar 2020 06:46:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ceEJnNFoeHcdoqoNMp3EVLqaBMfP/Xg0qWnfouvdXUo=; b=Yctv4NQu0zY1ahvJJbiKMvE0o/awj/7seFAFQV15/frE/5tXdQ6UVIQeihqBGNS7OF FGpjWmVRNIFLlFtnjaJol2tHyc2SXFffUD/4FKl+wawzgPovuKHRVOUkj0wn4vGCoVcW UGObJ4wM9c34s8tyQzEAsWvxcRtzVDXaE8gfiGI2tLEDNVz2as1z12Q1XRuZyh7CgPnE O73OBDL/jUULswhxJ2dQo8/h1xpaLziqjGVhpE3iMSOI67J+VZ4qZ7EVkCJyQooCvTL5 Uyfs/pqHcyb3HVrtwA1P0ksI8vC1bDrYeksAKn93dzmvngk0fHXNozFbfRMcdzC2wnDd S0Jg== X-Gm-Message-State: ANhLgQ3FE8mxmaOSMgWcaILJ6mOXJ3KmhEbqk0c7Ce7+vdizfFL6Bn+Y gUDhm5xLxB+ALTs260/YiubrjjzriD0M1e9nJHLtsw== X-Google-Smtp-Source: ADFU+vsq2UbJoPyBDXjSmtySUm3WMjgKUrq5yEd7LPlsKtnnO9gSkcw4SiPF8yr+R5H1PQflKotF//NGuXnAo43sFEs= X-Received: by 2002:a6b:e806:: with SMTP id f6mr23939658ioh.52.1584366398905; Mon, 16 Mar 2020 06:46:38 -0700 (PDT) MIME-Version: 1.0 References: <202003141943.02EJhixQ093985@repo.freebsd.org> <20200316115527.GL8028@zxy.spb.ru> In-Reply-To: <20200316115527.GL8028@zxy.spb.ru> From: Patrick Kelsey Date: Mon, 16 Mar 2020 09:46:27 -0400 Message-ID: Subject: Re: svn commit: r358995 - head/sys/net To: Slawa Olhovchenkov Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 48gyJc4F2qz3Nl5 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pkelsey@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=pkelsey@gmail.com X-Spamd-Result: default: False [-4.24 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[48.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.24)[ip: (-6.54), ipnet: 209.85.128.0/17(-2.97), asn: 15169(-1.65), country: US(-0.05)]; FORGED_SENDER(0.30)[pkelsey@freebsd.org,pkelsey@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[48.166.85.209.rep.mailspike.net : 127.0.0.17]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[pkelsey@freebsd.org,pkelsey@gmail.com]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2020 13:46:43 -0000 On Mon, Mar 16, 2020 at 7:55 AM Slawa Olhovchenkov wrote: > On Sat, Mar 14, 2020 at 07:43:44PM +0000, Patrick Kelsey wrote: > > > Author: pkelsey > > Date: Sat Mar 14 19:43:44 2020 > > New Revision: 358995 > > URL: https://svnweb.freebsd.org/changeset/base/358995 > > > > Log: > > Fix iflib freelist state corruption > > > > This fixes a bug in iflib freelist management that breaks the required > > correspondence between freelist indexes and driver ring slots. > > > > PR: 243126, 243392, 240628 > > Are you sure? > Bug 240628 - sysutils/zfsnap2: Completion script link for zsh has > wrong path > > Unfortunately, that should be 240608, not 240628. > > Reported by: avg, alexandr.oleynikov@gmail.com, Harald > Schmalzbauer > > Reviewed by: avg, gallatin > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D23943 > > Very interesting. > Is this related to my problem? > I am have trouble w/ netmap: > > 1. netmap reported RX slots filled all ring (tail == head-1) > 2. application processed all RX slots and reported to nemap (head == tail) > 3. RX stuck. > > workaround: report on step 2 head = tail-1 (one RX slots left > unprocessed). > > Also I am have trouble w/ TX, similar. > This commit changes code that netmap does not use. netmap freelist refill is handled via netmap_fl_refill() in iflib.c, and that was not examined as part of this work. -Patrick