From owner-svn-src-head@FreeBSD.ORG  Mon Jul 15 09:47:02 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id EC63BE7E;
 Mon, 15 Jul 2013 09:47:02 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 by mx1.freebsd.org (Postfix) with ESMTP id 776DCBF7;
 Mon, 15 Jul 2013 09:47:02 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id r6F9l1ka030486;
 Mon, 15 Jul 2013 13:47:01 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id r6F9l1dB030485;
 Mon, 15 Jul 2013 13:47:01 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Mon, 15 Jul 2013 13:47:01 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Adrian Chadd <adrian@FreeBSD.org>
Subject: Re: svn commit: r253314 - head/sys/net
Message-ID: <20130715094701.GO8839@FreeBSD.org>
References: <201307130425.r6D4P31J078644@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201307130425.r6D4P31J078644@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jul 2013 09:47:03 -0000

On Sat, Jul 13, 2013 at 04:25:03AM +0000, Adrian Chadd wrote:
A> Author: adrian
A> Date: Sat Jul 13 04:25:03 2013
A> New Revision: 253314
A> URL: http://svnweb.freebsd.org/changeset/base/253314
A> 
A> Log:
A>   Bring over some link aggregation / LACP protocol improvements and debugging
A>   additions.
A>   
A>   * Add some new tracing events to aid in debugging.
A>   * Add in a debugging mode to drop transmit and received frames, specifically
A>     to test whether seeing or hearing heartbeats correctly cause LACP to
A>     drop the port.
A>   * Add in (and make default) a strict LACP mode, which requires the
A>     heartbeat on a port to be heard before it's used.  Sometimes vendor ports
A>     will hang but the link layer stays up, resulting in hung traffic.
A>   * Add logging the number of link status flaps, again to aid in debugging
A>     badly behaving switch ports.
A>   * Calculate the lagg interface port speed as the multiple of the
A>     configured ports, rather than the largest.

Having the txtest, rxtest and lacp_strict a global sysctls makes them
useless on a box that has more than one aggregate interface. Turning
test on will down all laggs on a box.

IMO, these should be ioctls that can be configured per-interface via
ifconfig, and in perfect case documented in ifconfig.8.

-- 
Totus tuus, Glebius.