Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Feb 2011 21:48:12 +0800 (CST)
From:      Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/154653: [PATCH] Mk/bsd.port.mk: unify the message with real URL by removing superfluous slash
Message-ID:  <20110210134812.BD5E52AEC4A8@sunpoet.net>
Resent-Message-ID: <201102101350.p1ADoDUn038319@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         154653
>Category:       ports
>Synopsis:       [PATCH] Mk/bsd.port.mk: unify the message with real URL by removing superfluous slash
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 10 13:50:13 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Sunpoet Po-Chuan Hsieh
>Release:        FreeBSD 8.2-PRERELEASE amd64
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD bonjour.sunpoet.net 8.2-PRERELEASE FreeBSD 8.2-PRERELEASE #0: Sat Feb 5 00:35:18 CST 2011 sunpoet@bonjour.sunpoet.net:/usr/obj/usr/src/sys/bonjour amd64

	
>Description:
- Unify the message with real URL by removing superfluous slash
  ${site} already contains a trailing slash.

Take multimedia/quvi for example.
message: http://quvi.googlecode.com/files//quvi-0.2.13.tar.xz
real URL: http://quvi.googlecode.com/files/quvi-0.2.13.tar.xz

% cd /usr/ports/multimedia/quvi
% make distclean
% make FETCH_ARGS+=-v fetch
=> quvi-0.2.13.tar.xz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch http://quvi.googlecode.com/files//quvi-0.2.13.tar.xz
looking up quvi.googlecode.com
connecting to quvi.googlecode.com:80
requesting http://quvi.googlecode.com/files/quvi-0.2.13.tar.xz
remote size / mtime: 306460 / 1297109088
quvi-0.2.13.tar.xz                            100% of  299 kB  184 kBps

	
>How-To-Repeat:
	
>Fix:

--- bsd.port.mk.patch begins here ---
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.668
diff -u -r1.668 bsd.port.mk
--- bsd.port.mk	7 Feb 2011 13:50:13 -0000	1.668
+++ bsd.port.mk	10 Feb 2011 13:23:30 -0000
@@ -3571,7 +3571,7 @@
 				SORTED_MASTER_SITES_CMD_TMP="${SORTED_MASTER_SITES_DEFAULT_CMD}" ; \
 			fi; \
 			for site in `eval $$SORTED_MASTER_SITES_CMD_TMP ${_RANDOMIZE_SITES}`; do \
-			    ${ECHO_MSG} "=> Attempting to fetch $${site}/$${file}"; \
+			    ${ECHO_MSG} "=> Attempting to fetch $${site}$${file}"; \
 				CKSIZE=`alg=SIZE; ${DISTINFO_DATA}`; \
 				case $${file} in \
 				*/*)	${MKDIR} $${file%/*}; \
@@ -3623,7 +3623,7 @@
 				SORTED_PATCH_SITES_CMD_TMP="${SORTED_PATCH_SITES_DEFAULT_CMD}" ; \
 			fi; \
 			for site in `eval $$SORTED_PATCH_SITES_CMD_TMP`; do \
-			    ${ECHO_MSG} "=> Attempting to fetch $${site}/$${file}"; \
+			    ${ECHO_MSG} "=> Attempting to fetch $${site}$${file}"; \
 				CKSIZE=`alg=SIZE; ${DISTINFO_DATA}`; \
 				case $${file} in \
 				*/*)	${MKDIR} $${file%/*}; \
--- bsd.port.mk.patch ends here ---
	


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110210134812.BD5E52AEC4A8>