From owner-freebsd-net@FreeBSD.ORG Thu Jul 31 21:50:03 2008 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0586106566B for ; Thu, 31 Jul 2008 21:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DC12D8FC15 for ; Thu, 31 Jul 2008 21:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m6VLo3ha087738 for ; Thu, 31 Jul 2008 21:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m6VLo3ET087737; Thu, 31 Jul 2008 21:50:03 GMT (envelope-from gnats) Date: Thu, 31 Jul 2008 21:50:03 GMT Message-Id: <200807312150.m6VLo3ET087737@freefall.freebsd.org> To: freebsd-net@FreeBSD.org From: Wooseog Choi Cc: Subject: Re: kern/114714: [gre][patch] gre(4) is not MPSAFE and does not support keys X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Wooseog Choi List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jul 2008 21:50:04 -0000 The following reply was made to PR kern/114714; it has been noted by GNATS. From: Wooseog Choi To: , Cc: Subject: Re: kern/114714: [gre][patch] gre(4) is not MPSAFE and does not support keys Date: Thu, 31 Jul 2008 14:28:13 -0700 --_6b0f6d37-847d-4140-98e8-949ced352c50_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi=2C =20 My name is Ben Choi=2C working for Sandvine=2C Waterloo=2C ON=2C Canada. I had experienced similar issue=2C which was displaying many gre_out() cons= ole messages. At that moment=2C I could not access console at all. After applying the fix of MPSAFE codes only=2C it works fine.=20 No error messages on console at all. The benefit of this fix is two-fold. One=2C By removing all annoying messages=2C the console becomes accessible. Two=2C no gre packets are dropped by this incorrect error messages. =20 As the result=2C I think this code is worth to merge into official build. =20 Kind regards=2C =20 Ben Choi _________________________________________________________________ Keep your kids safer online with Windows Live Family Safety. http://www.windowslive.com/family_safety/overview.html?ocid=3DTXT_TAGLM_WL_= family_safety_072008= --_6b0f6d37-847d-4140-98e8-949ced352c50_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi=2C
=3B
My name is Ben Choi=2C working for Sandvine=2C Waterloo=2C ON=2C Canada. I had experienced similar issue=2C which was displaying many gre_out() cons= ole messages.
At that moment=2C I could not access console at all.
After applying the fix of MPSAFE codes only=2C it works fine.
No error messages on console at all.
The benefit of this fix is two-fold.
One=2C By removing all annoying messages=2C the console becomes accessible.=
Two=2C no gre packets are dropped by this incorrect error messages.
=3B
As the result=2C I think this code is worth to merge into official build. =3B
Kind regards=2C
=3B
Ben Choi

Keep your kids safer online with Windows Live Famil= y Safety. Help protect you= r kids. = --_6b0f6d37-847d-4140-98e8-949ced352c50_--