From nobody Fri Mar 13 18:54:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fXYZ31J0jz6VZvT for ; Fri, 13 Mar 2026 18:54:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fXYZ26PKwz3Snf for ; Fri, 13 Mar 2026 18:54:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773428074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Yhc/L/1NbBfMwvYrhJ4PQUiRNckRP9VaWGTAPYhc5h0=; b=hqHXLmk6MQ8m+vDZc2JK+PqNnrylibRtbDcA1i4ZrVXU+iyx5xdICf9nN/49r0fcvLY0RG 65G4L7FrHxF5urw914eTi72w/A9OhHDwchbfg5Ig2M9B85T2VCk/BxU/Z9+zn0+eNifGIl qD80ah3XrUGWTDVpq7PyDSVoSkAUoiit+/jfGLD6zY2a7vx6IoMBOoiBZKt/tBZAV8u7o0 OuV1Hmpr0RVD9ue2XlAFX5WVdyQpM2T+2fVqZq2RFwmVWhHZyCiDzkdXsrJ9z3CMAgVYqS tWHpPjjBOHHPVQ9hqqJoH11we7YjKTI+v2+70jzH0ucdduNcivYDfB1hrgdvNQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773428074; a=rsa-sha256; cv=none; b=a2BbubnLFqExFyzO4sCCDjaKyAPp524sJsYv0peaAsB7NKyTIai4ADtIayUNWgu9hWsd+M vv26H4THC+VI9j9kBsvm5HdrvA2kfIHAzw0+EqJgX+pUkBadA/zp36ONbQ8Q0I2kiX5qAM Gt2wkG7A4yZl7ekZkMKZCDmB0H0PErcyUUhb29VSicsCJn1mptOGkqAkNhQE0+4qjU+JY/ g3mJrR9Hk2T21ucCxNVwhytSa0szHYGv+53hqmuD3x5BCCnc/JEoP/nR8qtwI9HY0eL3T4 TdvYSdcOBAmo+0WEGYrcj3orl/ttG6ogEXNviQqawuefYHrVDI/ZHifEf/zoIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773428074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Yhc/L/1NbBfMwvYrhJ4PQUiRNckRP9VaWGTAPYhc5h0=; b=DIMJC41XqBvvzxTcn2wkKd2HVyzCQ8/ANXmVNIzW/1XI2cTG9CrWmVLjQfuJ6+fHruOeP+ bWNaeA0O2EpqXih4zIujSxoUtccYVrN9/fDk01dPFiS06ay5q2vFSGINrW3iQhy9VfewOL nqB3FNLFshurP+JD8CXl4+b3nTRJ5XqFcSSJu4UJyD8G0YqWX/U7+dGXRe03vGgTTu+iew YaxmeTymY3seQczNetm/RKbY01MALEJwvBdY2FFamAx+BQrbfvOrRLKZRILUMHakgvcySi S8+OiX5vHmB5a3D94nH8W8esxyieMDJ7VkSJrQzwAYTZIw9NklVd211J+DIdvw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fXYZ25MLrzlP4 for ; Fri, 13 Mar 2026 18:54:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 323fe by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 13 Mar 2026 18:54:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Justin Hibbits Subject: git: 703901bce15b - main - i6300esbwd: Set error appropriately on event List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhibbits X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 703901bce15bdd746cb20ab3fc88f5859924cf76 Auto-Submitted: auto-generated Date: Fri, 13 Mar 2026 18:54:34 +0000 Message-Id: <69b45d6a.323fe.315f786c@gitrepo.freebsd.org> The branch main has been updated by jhibbits: URL: https://cgit.FreeBSD.org/src/commit/?id=703901bce15bdd746cb20ab3fc88f5859924cf76 commit 703901bce15bdd746cb20ab3fc88f5859924cf76 Author: Justin Hibbits AuthorDate: 2026-03-13 18:49:17 +0000 Commit: Justin Hibbits CommitDate: 2026-03-13 18:49:17 +0000 i6300esbwd: Set error appropriately on event Per the watchdog driver contract, if the driver successfully arms the watchdog it must set error to 0, and if it's unable to arm the watchdog it must leave error alone. Sponsored by: Hewlett Packard Enterprise --- sys/dev/ichwd/i6300esbwd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/ichwd/i6300esbwd.c b/sys/dev/ichwd/i6300esbwd.c index 03d504a350aa..e810dcd888c4 100644 --- a/sys/dev/ichwd/i6300esbwd.c +++ b/sys/dev/ichwd/i6300esbwd.c @@ -112,7 +112,6 @@ i6300esbwd_event(void *arg, unsigned int cmd, int *error) cmd &= WD_INTERVAL; if (cmd != 0 && (cmd < WD_TO_1MS || (cmd - WD_TO_1MS) >= WDT_PRELOAD_BIT)) { - *error = EINVAL; return; } timeout = 1 << (cmd - WD_TO_1MS); @@ -148,6 +147,8 @@ i6300esbwd_event(void *arg, unsigned int cmd, int *error) regval = i6300esbwd_lock_read(sc); sc->locked = regval & WDT_LOCK; } + /* Set error to 0 to indicate we did something. */ + *error = 0; } static int