From owner-svn-src-all@freebsd.org Thu Nov 24 14:58:31 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79B85C53ED3; Thu, 24 Nov 2016 14:58:31 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg0-x236.google.com (mail-pg0-x236.google.com [IPv6:2607:f8b0:400e:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 51F306B5; Thu, 24 Nov 2016 14:58:31 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg0-x236.google.com with SMTP id p66so19434701pga.2; Thu, 24 Nov 2016 06:58:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fi95XDY6N4KxvBTrQkyuHuTwKmpNwpiEa/LhaQe0Z6o=; b=pCm41soHnAGO+vJQwaoxijWQ8D4/QdD01cfKA1/Vtrd6ZN810udGl/c1VvbcebJQvp AasDXtzdJhJP7QaHLsHXOQONcl1hmnPU5a01mn7jwcfuFBpZbB+zv/ss+8+0z934WbBc LW9ld/P1AYK14JtRmOdkK8wXHMRtzBQaljseY/hWfTyKR8uwxkZ8aMCpXRke1kHsCV1t LSxDIdpJW7JP3Nakk+WhL6buZ2MyI8d1vnrscodEA/aGqlT3r5clkpTX5hBBM76vjf7Y pAWpwTZu94IFxciTbw1fv7f2TKZ9injguwT8NAZasZmuZvMCGxBVLeSK02DMSWM31PdY YeJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:reply-to:subject:to:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=fi95XDY6N4KxvBTrQkyuHuTwKmpNwpiEa/LhaQe0Z6o=; b=D4ogVLSgXHpvgMSKPGavHtmbZ3t1HIRd++2bVXuZxY5z41GA0bYCgy4V43PQaX0A0/ AMUvcHH4hUdpI7b1+3qtvjZ7RY0leF1lpsiQzcwG7k+xQDhSDH7QqvR6PV/5uSjpGMkd N+QIw7tpplyTgmFZUIA8NnGFKsNu5klnTIGpBWaMY0V1VFkfpc36tOykXfqVR6b+dpHV cNAO3VCQm6FXG3ZYDaGw7xlUKWHQbWNiohNvClqa6sG1f9+BlPRO36QXZ6QeTIVz6qIA /ERZw4BCVLV7NfvJio7UDdOm/1oQWiAMAv3Y0pNa/WufkXqimc3fzsyFU+VGnWTONBIn 4uNw== X-Gm-Message-State: AKaTC0115YuQaSzPum/czykd8VRi3bzjRHvyJhD8/PHmeyKeNo3YiBImHTiCqX7wCGHtNQ== X-Received: by 10.84.210.73 with SMTP id z67mr6344297plh.112.1479999510252; Thu, 24 Nov 2016 06:58:30 -0800 (PST) Received: from ?IPv6:2001:44b8:31ae:7b01:4432:31af:138c:5cd2? (2001-44b8-31ae-7b01-4432-31af-138c-5cd2.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:4432:31af:138c:5cd2]) by smtp.gmail.com with ESMTPSA id z62sm61133400pfz.19.2016.11.24.06.58.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Nov 2016 06:58:29 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r309109 - head/lib/libutil To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201611241450.uAOEoLA5079215@repo.freebsd.org> From: Kubilay Kocak Message-ID: Date: Fri, 25 Nov 2016 01:56:36 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0a2 MIME-Version: 1.0 In-Reply-To: <201611241450.uAOEoLA5079215@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 14:58:31 -0000 On 25/11/2016 1:50 AM, Dag-Erling Smørgrav wrote: > +/* + * Reliably open and lock a file. + * + * DO NOT, UNDER PAIN OF > DEATH, modify this code without first reading the + * revision > history and discussing your changes with . + * Don't > be fooled by the code's apparent simplicity; there would be no + * > need for this function if it was as easy to get right as you think. + > */ This comes as close to obvious territoriality in FreeBSD as I've seen to date and it's especially disappointing to see coming from someone many look up to and consider a senior project developer. While we all may understand the frustration associated with people changing code they don't understand, I believe we need less fear associated with contributing to FreeBSD and that this is a big step in the wrong direction. Please choose a better way to resolve the perceived problem. -- Respectfully, ./koobs