From owner-svn-ports-head@freebsd.org Tue Jul 7 13:11:03 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4D386362978; Tue, 7 Jul 2020 13:11:03 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from wforward4-smtp.messagingengine.com (wforward4-smtp.messagingengine.com [64.147.123.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B1N9L6mKTz4b7P; Tue, 7 Jul 2020 13:11:02 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.west.internal (Postfix) with ESMTP id 33CE2D21; Tue, 7 Jul 2020 09:11:01 -0400 (EDT) Received: from imap1 ([10.202.2.51]) by compute2.internal (MEProxy); Tue, 07 Jul 2020 09:11:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=lLQfRO PKJBhFKN2/0b2D0QnVon2KEodMrQk8S2Yu2u8=; b=desVcHfTzGYzMTeu5S38R3 nLNrce52tt+kDfMK7Nv6sq2Kh5fY81c2YPvTqtywDOvJ9Cx1edcDctjFagructsq 3tKMJyV/APCqM5duTqROY4F4UnoLYojyNZkJ7tmo/7v8cc7fNUQSBVDWYuI/TYc4 CpPJ0DIWDm4SYUEoL7IO9jtYMRAIwOpWEm8pwCd2z81Jj5RI5m/xhCHJj9550i6J La8REWXyK5/eEsMARj+ojLsbdA/hXlsH9NCxARr43GtZu5kLuisLA9pWwcPh45YE ySAaimWI1CqsLXixCTc0Oi0HhKnuwFZjRmMequEtkSZymEU3xTJp2zvJGgR5SV4Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehgdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpedfvfhosghi rghsucfmohhrthhkrghmphdfuceothhosghikheshfhrvggvuefuffdrohhrgheqnecugg ftrfgrthhtvghrnhepvdehueeljeevtdeklefhgedvuddttdeukeetffevveeguddtfffh teejhedthffgnecuffhomhgrihhnpehfrhgvvggsshgurdhorhhgpdhtohgsihhkrdhmvg enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehtohgs ihhksefhrhgvvgeuufffrdhorhhg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7D4E9C200A5; Tue, 7 Jul 2020 09:11:00 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-dev0-576-gfe2cd66-fm-20200629.001-gfe2cd668 Mime-Version: 1.0 Message-Id: In-Reply-To: <202007071227.067CRINg025699@repo.freebsd.org> References: <202007071227.067CRINg025699@repo.freebsd.org> Date: Tue, 07 Jul 2020 13:10:34 +0000 From: "Tobias Kortkamp" To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Cc: "Li-Wen Hsu" Subject: =?UTF-8?Q?Re:_svn_commit:_r541417_-_in_head:_audio/bambootracker_audio/z?= =?UTF-8?Q?ynaddsubfx_comms/nanovna-saver_comms/openzwave-devel_comms/te?= =?UTF-8?Q?lldus-core_comms/tlf_databases/arrow_deskutils/cairo-dock-plu?= =?UTF-8?Q?gins_devel/bossa_...?= Content-Type: text/plain X-Rspamd-Queue-Id: 4B1N9L6mKTz4b7P X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; ASN(0.00)[asn:11403, ipnet:64.147.123.0/24, country:US] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2020 13:11:03 -0000 On Tue, Jul 7, 2020, at 12:53, Li-Wen Hsu wrote: > On Tue, Jul 7, 2020 at 8:27 PM Tobias Kortkamp wrote: > > > > Author: tobik > > Date: Tue Jul 7 12:27:18 2020 > > New Revision: 541417 > > URL: https://svnweb.freebsd.org/changeset/ports/541417 > > > > Log: > > Clean up some things > > > > Reported by: portscan and common sense > > Hi Tobias, > > I am somehow worried that this commit might cause some people's > objection. It does fix many things, which is great, but also: > - Changed (direct) dependency but not bump PORTREVISION (comms/nanovna-saver) I did not change any dependencies. What did I miss? > - Touched some style preference (print/pdfchain) The previous style causes active harm in readability and causes additional cognitve load on committers. See the commit message of r541362 for a direct example of this. Also style fixes are very much covered by the blanket. I quote chapter 5.5 from the Porter's Handbook: "We reserve the right to modify the maintainer's submission to better match existing policies and style of the Ports Collection without explicit blessing from the submitter or the maintainer. Also, large infrastructural changes can result in a port being modified without the maintainer's consent. These kinds of changes will never affect the port's functionality." https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-maintainer.html For pdfchain it IMHO should have been done before the initial import into the tree. > - Without notifying port's maintainer nor not having approval from porgmr > > Sorry that if I didn't notice there was a policy change that those > changes are also covered by blanket approval, and I'm a bit worried > about the last one, maybe the better way is file a PR with the patch > and let MAINTAINER have time to response (or use maintainer timeout > after two weeks)? If I have misinterpreted the blanket and if commits like this are indeed not covered by it, I would rather refrain from making commits like this in the future because I will not cause extra work for myself and file PRs for these trivial fixes. That is asking way too much. > BTW, what's "porscan"? I didn't notice that tool. Sounds useful and > can you tell me more about it? It's part of ports-mgmt/portfmt and will flag stuff like you see here. I run it regularly and results are published here: https://pkg.tobik.me/portscan/