From owner-svn-src-all@FreeBSD.ORG Fri May 11 13:03:29 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 59303106578D for ; Fri, 11 May 2012 13:03:29 +0000 (UTC) (envelope-from bounces+73574-8822-svn-src-all=freebsd.org@sendgrid.me) Received: from o3.shared.sendgrid.net (o3.shared.sendgrid.net [208.117.48.85]) by mx1.freebsd.org (Postfix) with SMTP id E21268FC08 for ; Fri, 11 May 2012 13:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h= message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=SOL4OsfmV6CNL166prskglHstJw=; b=K2al4h2KJjcGNIxxz8DGSUUHd9Se WxWF6pa8ykaCxWGsTBUwwy3ZoJcukXcr+ZMcvwxRSvx8QqbU2aSz2isXkDXKDld9 EivqsRo9x5CkKZ9xFMsM3pBy50Lu0AUayjoKLCcOegQsC79rDGkDFBkkunBTu48F Vd10CZB+IjK1RmE= Received: by 10.12.16.10 with SMTP id mf41.29053.4FAD0E188 Fri, 11 May 2012 08:03:20 -0500 (CDT) Received: from mail.tarsnap.com (unknown [10.9.180.5]) by mi12 (SG) with ESMTP id 4fad0e18.7eb5.1eea2a for ; Fri, 11 May 2012 08:03:20 -0500 (CST) Received: (qmail 23758 invoked from network); 11 May 2012 12:56:39 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by mail.tarsnap.com with ESMTP; 11 May 2012 12:56:39 -0000 Received: (qmail 8547 invoked from network); 11 May 2012 13:02:44 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 11 May 2012 13:02:44 -0000 Message-ID: <4FAD0DF4.9000609@freebsd.org> Date: Fri, 11 May 2012 06:02:44 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120509 Thunderbird/12.0.1 MIME-Version: 1.0 To: Konstantin Belousov References: <201205111237.q4BCbGX2083596@svn.freebsd.org> <20120511124820.GN2358@deviant.kiev.zoral.com.ua> In-Reply-To: <20120511124820.GN2358@deviant.kiev.zoral.com.ua> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Sendgrid-EID: A6W2xSVPHetogaU8rnzccWwgBYtN+QvIzXyjfe/10PHhjt1B/BnZOEqCDFLrqNg4qhNIfTFLeKD88FILKgHVTCY7eIahtfjJpJtgixICkNhk+sBN2D/mCvjehnWjNHZECGRe+Cmf3tYeYEI6zTYNKq/oyozYNUJ9R7VFcklFHxM= Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Gabor Kovesdan Subject: Re: svn commit: r235267 - in head/usr.bin/sort: . nls X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2012 13:03:29 -0000 On 05/11/12 05:48, Konstantin Belousov wrote: > On Fri, May 11, 2012 at 12:37:16PM +0000, Gabor Kovesdan wrote: >> +bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static >> unsigned char **cmonths = NULL; > > Such initializations are useless. You only increase the size of the binary > on the disk as the consequence. I just tested this hypothesis, and found no change in binary size using either clang or gcc46. Presumably they're smart enough to ignore explicit (and unnecessary) initializations of statics to zero. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid