From owner-freebsd-current@FreeBSD.ORG  Thu Mar 11 08:04:27 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 040D516A4CF
	for <current@FreeBSD.org>; Thu, 11 Mar 2004 08:04:27 -0800 (PST)
Received: from smtp.mho.com (smtp.mho.net [64.58.4.5])
	by mx1.FreeBSD.org (Postfix) with SMTP id A91D943D53
	for <current@FreeBSD.org>; Thu, 11 Mar 2004 08:04:26 -0800 (PST)
	(envelope-from scottl@freebsd.org)
Received: (qmail 57430 invoked by uid 1002); 11 Mar 2004 16:04:26 -0000
Received: from unknown (HELO freebsd.org) (64.58.1.252)
  by smtp.mho.net with SMTP; 11 Mar 2004 16:04:26 -0000
Message-ID: <40508D43.6090802@freebsd.org>
Date: Thu, 11 Mar 2004 09:01:07 -0700
From: Scott Long <scottl@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040304
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Lukas Ertl <le@FreeBSD.org>
References: <20040310132923.GA58989@stud.fit.vutbr.cz>
	<404FE5A7.1070508@freebsd.org> <20040311091857.W628@korben.in.tern>
In-Reply-To: <20040311091857.W628@korben.in.tern>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: Greg 'groggy' Lehey <grog@FreeBSD.org>
cc: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
cc: current@FreeBSD.org
Subject: Re: RELENG_5_2 doesnt compile
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Mar 2004 16:04:27 -0000

Lukas Ertl wrote:
> On Wed, 10 Mar 2004, Scott Long wrote:
> 
> 
>>Divacky Roman wrote:
>>
>>>HI
>>>
>>>freshly cvsuped RELENG_5_2 doesnt compile in vinum.c
>>>in function vinumattach:136,143,150,162
>>>
>>>p_intr_nesting_level not being member of a structure.
>>>
>>>roman
>>
>>
>>It looks like compiling vinum without VINUMDEBUG triggers this.  Since
>>the module uses VINUMDEBUG, and LINT uses VINUMDEBUG, and vinum isn't
>>enabled in GENERIC, this wasn't detected.  Hopefully one of the vinum
>>maintainers can look into this and correct it.
> 
> 
> I'm not quite sure what's wrong here.  Did you compile vinum into the
> kernel?  Obviously the comment in sys/conf/NOTES is wrong, you must set
> VINUMDEBUG to match the value in sys/modules/vinum/Makefile.
> 
> regards,
> le
> 

If you try compiling vinum (either as a module or in the kernel) without
setting the VINUMDEBUG option, it will fail.  The 'Malloc' macro in
vinumext.h gropes around in td_proc (strike 1) for a field that no
longer exists (strike 2), but only does this in the non-VINUMDEBUG case
(strike 3).


Scott