From owner-freebsd-java@freebsd.org Sat May 15 15:58:17 2021 Return-Path: Delivered-To: freebsd-java@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AD97C6492F2 for ; Sat, 15 May 2021 15:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Fj96K4NKcz4ywm for ; Sat, 15 May 2021 15:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 964E7649798; Sat, 15 May 2021 15:58:17 +0000 (UTC) Delivered-To: java@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9614E6492F1 for ; Sat, 15 May 2021 15:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fj96K3ppDz506l for ; Sat, 15 May 2021 15:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6CBA91E1 for ; Sat, 15 May 2021 15:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 14FFwHEL034022 for ; Sat, 15 May 2021 15:58:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 14FFwHE3034021 for java@FreeBSD.org; Sat, 15 May 2021 15:58:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: java@FreeBSD.org Subject: maintainer-feedback requested: [Bug 255905] java/openjdk16: Fix compile error with clang 12 Date: Sat, 15 May 2021 15:58:17 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: java@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 May 2021 15:58:17 -0000 Bugzilla Automation has asked freebsd-java (Nobody) for maintainer-feedback: Bug 255905: java/openjdk16: Fix compile error with clang 12 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255905 --- Description --- During an exp-run for llvm 12 (see bug 255570), it turned out that at least openjdk11 and openjdk12 do not build with clang 12.0.0. The exp-run therefo= re skipped openjdk16. Building this manually shows that it results in a compile error: gmake[4]: Leaving directory '/wrkdirs/share/dim/ports/java/openjdk16/work/jdk16u-jdk-16.0.1-9-1/make' /wrkdirs/share/dim/ports/java/openjdk16/work/jdk16u-jdk-16.0.1-9-1/src/hots= pot/ cpu/x86/vm_version_ext_x86.cpp:748:3: error: suspicious concatenation of string literals in an array initializati= on; did you mean to separate the elements with a comma? [-Werror,-Wstring-concatenation] "", ^ /wrkdirs/share/dim/ports/java/openjdk16/work/jdk16u-jdk-16.0.1-9-1/src/hots= pot/ cpu/x86/vm_version_ext_x86.cpp:747:3: note: place parentheses around the string literal to silence warning "Opteron QC/Phenom" // Barcelona et.al. ^ 1 error generated. This is due to a missing backport of this commit [1]: commit f8a9602a0a65cdc98eb940aac9529256ded2bf42 Author: Yasumasa Suenaga Date: Thu Jan 21 06:08:13 2021 +0000 8260025: Missing comma in VM_Version_Ext::_family_id_amd Reviewed-by: dholmes, stuefe I have attached a patch that adds this commits as an additional patch. [1] https://github.com/openjdk/jdk/commit/f8a9602a0a65cdc98eb940aac9529256ded2b= f42